Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Preliminary Implementation of Quick Search #191499

Closed
3 tasks done
andreamah opened this issue Aug 28, 2023 · 0 comments
Closed
3 tasks done

Test Preliminary Implementation of Quick Search #191499

andreamah opened this issue Aug 28, 2023 · 0 comments

Comments

@andreamah
Copy link
Contributor

andreamah commented Aug 28, 2023

Refs #189964, #190767, #191088

Complexity: 5

Create Issue


Background:

This iteration, I introduced Quick Search, which is a quick access menu that shows search results. It is meant to show a quick glimpse of search results without jumping to the search view. Eventually, we also hope copilot to offer semantic text search results through this menu.

The following demo shows three different search examples coming from it using three different ways of accessing it. You can access it via:

  • Typing % followed by your query in the quick open (the blank picker).
  • The Search: Quick Text Search (Experimental) command.
  • The list item in the command center.
2023-08-24.11-26-13.mp4

Testing:

This TPI is pretty open-ended, hence the high complexity rating.

Firstly, make sure that the following works as expected:

  • You can access this feature via the three ways listed above.
  • In files that have more than 10 matches, ensure that clicking the "... More" item takes you to the search viewlet with the correct item focused.
  • Results from open editors appear first, then ones from closed editors. Ensure these results don't repeat.

From then, just play around with the feature and ensure that it works as expected. Feel free to make feature requests for what you think is missing from this experience. I'd like to hear what you think of it!

Below are some main features that I'm going to be looking into in following iterations (in no particular order)

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants