Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings feedback #191618

Closed
bpasero opened this issue Aug 29, 2023 · 6 comments · Fixed by #191642
Closed

Settings feedback #191618

bpasero opened this issue Aug 29, 2023 · 6 comments · Fixed by #191642
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Aug 29, 2023

Testing #191527

Two polish items:

  • the link to the setting does not seem to work
  • you talk about "making the focused view more obvious" but that is not true, this feature only works for "text editors" and "terminals", so I would clarify that

Image

@bpasero
Copy link
Member Author

bpasero commented Aug 29, 2023

Btw should this move under a settings category for accessibility rather than "View"? Is that maybe the intent of this setting to improve accessibility?

No other "view" than a text editor and terminal is impacted, so thats why I feel the settings scope seems off.

@Tyriar
Copy link
Member

Tyriar commented Aug 29, 2023

Btw should this move under a settings category for accessibility rather than "View"? Is that maybe the intent of this setting to improve accessibility?

That's actually where it was initially, see #30522 (comment) and follow up comments. It does have the accessibility tag fwiw, I don't feel too strongly about the setting name though.

you talk about "making the focused view more obvious" but that is not true, this feature only works for "text editors" and "terminals", so I would clarify that

This is already covered? "View" is referring to the aforementioned views:

image

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Aug 29, 2023
@Tyriar Tyriar added this to the August 2023 milestone Aug 29, 2023
@bpasero
Copy link
Member Author

bpasero commented Aug 29, 2023

My settings description suggestion: "Whether to dim unfocussed text editors and terminals, making the focused text editor or terminal more obvious"

Once all editors are supported, we can leave out "text".

@Tyriar
Copy link
Member

Tyriar commented Aug 29, 2023

That just reads awkwardly to me repeating the same words multiple times.

Once all editors are supported, we can leave out "text".

Planning on fixing the majority of editors this week 👌

@Tyriar
Copy link
Member

Tyriar commented Aug 29, 2023

After the discussion in the other issues I do agree we should move this back to accessibility to further avoid confusion about it applying to all views.

@Tyriar
Copy link
Member

Tyriar commented Aug 29, 2023

I will also clarify in the setting description that it's purpose is to help the user know where input is going to go.

Tyriar added a commit that referenced this issue Aug 29, 2023
@aiday-mar aiday-mar added the verified Verification succeeded label Aug 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants