-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings feedback #191618
Comments
Btw should this move under a settings category for accessibility rather than "View"? Is that maybe the intent of this setting to improve accessibility? No other "view" than a text editor and terminal is impacted, so thats why I feel the settings scope seems off. |
That's actually where it was initially, see #30522 (comment) and follow up comments. It does have the accessibility tag fwiw, I don't feel too strongly about the setting name though.
This is already covered? "View" is referring to the aforementioned views: |
My settings description suggestion: "Whether to dim unfocussed text editors and terminals, making the focused text editor or terminal more obvious" Once all editors are supported, we can leave out "text". |
That just reads awkwardly to me repeating the same words multiple times.
Planning on fixing the majority of editors this week 👌 |
After the discussion in the other issues I do agree we should move this back to accessibility to further avoid confusion about it applying to all views. |
I will also clarify in the setting description that it's purpose is to help the user know where input is going to go. |
Testing #191527
Two polish items:
The text was updated successfully, but these errors were encountered: