Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After the command is localized, it cannot be searched by keywords. #191880

Closed
yiliang114 opened this issue Aug 31, 2023 · 3 comments · Fixed by #191953
Closed

After the command is localized, it cannot be searched by keywords. #191880

yiliang114 opened this issue Aug 31, 2023 · 3 comments · Fixed by #191953
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded

Comments

@yiliang114
Copy link
Contributor

ADD ISSUE DESCRIPTION HERE

Version: 1.81.1
Commit: 6c3e3db
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36
Embedder: vscode.dev

bug3

Steps:

  1. Open vscode.dev or VS Code App
  2. Switch to a language other than the default, for example, Simplified Chinese.
  3. Search command by shortcut key, for example, search toggle, some matching commands will appear.
  4. But I search the keyword directly (incomplete command keyword), nothing will be matched.
@yiliang114
Copy link
Contributor Author

However, in the English environment, commands can be searched through keywords.
bug4

@TylerLeonhardt
Copy link
Member

This is similar to #157015 but easier to fix.

It isn't just scoped to Output.
image

There are a lot of these... and it all comes back to this allowing string here:

readonly title: ILocalizedString | string;

when I make that only accept ILocalizedString I get 47 compilation errors 😅

So, to fix this... we just need to:

  • Remove string as an option for title in IViewContainerDescriptor
  • Fix all compilation errors which really just means replacing all string titles with ILocalizedString titles

@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) labels Aug 31, 2023
@TylerLeonhardt TylerLeonhardt added this to the September 2023 milestone Aug 31, 2023
yiliang114 added a commit to yiliang114/vscode that referenced this issue Sep 1, 2023
@yiliang114
Copy link
Contributor Author

This is similar to #157015 but easier to fix.

It isn't just scoped to Output. image

There are a lot of these... and it all comes back to this allowing string here:

readonly title: ILocalizedString | string;

when I make that only accept ILocalizedString I get 47 compilation errors 😅

So, to fix this... we just need to:

  • Remove string as an option for title in IViewContainerDescriptor
  • Fix all compilation errors which really just means replacing all string titles with ILocalizedString titles

@TylerLeonhardt I have already followed your suggested steps and have dealt with it.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 1, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Sep 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
5 participants