Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similar command feedback #194909

Closed
TylerLeonhardt opened this issue Oct 5, 2023 · 3 comments · Fixed by #194920 or #195085
Closed

Similar command feedback #194909

TylerLeonhardt opened this issue Oct 5, 2023 · 3 comments · Fixed by #194920 or #195085
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-open Quick-open issues (search, commands) verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Oct 5, 2023

Version 1.83 ("September" (October?) 2023) brought "Similar command results in the Command Palette" what is a huge improvement. Query >git stash apply now brings relevant result ("Git: Apply Latest Stash"), just currently on the second place, after "Developer: Apply Update…":

Yet to find "File Utils: Move…" using >move file does not work; only >file move does.

Originally posted by @myfonj in #1964 (comment)

TylerLeonhardt added a commit that referenced this issue Oct 5, 2023
TylerLeonhardt added a commit that referenced this issue Oct 5, 2023
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Oct 5, 2023
@vscodenpa vscodenpa added this to the October 2023 milestone Oct 5, 2023
@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Oct 5, 2023

@myfonj I found out the issue... my PR ^ should have Git: Apply Latest Stash at the top of the list.... but it also allows File Utils: Move... to show up now.

That said, File Utils: Move... because the 2nd choice after File: New File... I think this is because our algorithm promotes matching with the word "File" higher than matching with the word "Move". A limitation of our algorithm... I've opened an issue to track an idea for this #194923

@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Oct 5, 2023

Verification:

  • On Windows open a repo in VS Code Insiders with a pending update (so this can't be verified until at least Monday... tomorrow, Insiders has the change, but we need another insiders to show the pending update)
  • Type in the Command Palette git stash apply - Git: Apply Latest Stash should be at the top of the results
  • Install the File Utils extension
  • Type in the Command Palette move file - File Utils: Move... should show up in the results somewhere.

@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug quick-open Quick-open issues (search, commands) labels Oct 5, 2023
@TylerLeonhardt TylerLeonhardt reopened this Oct 6, 2023
@vscodenpa vscodenpa removed the unreleased Patch has not yet been released in VS Code Insiders label Oct 6, 2023
@TylerLeonhardt
Copy link
Member Author

needed to revert the change because it caused some smoke test failures. I need to investigate further into why.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 8, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this issue Oct 26, 2023
@Tyriar Tyriar added the verified Verification succeeded label Oct 26, 2023
@aiday-mar aiday-mar added windows VS Code on Windows issues and removed windows-verification labels Oct 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-open Quick-open issues (search, commands) verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
5 participants