Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[object Object] in Settings Sync #195518

Closed
chrisdias opened this issue Oct 12, 2023 · 1 comment · Fixed by #195709
Closed

[object Object] in Settings Sync #195518

chrisdias opened this issue Oct 12, 2023 · 1 comment · Fixed by #195709
Assignees
@sandy081
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone
October 2023

Comments

@chrisdias
Copy link
Member

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version:
Version: 1.84.0-insider (user setup)
Commit: 9bb94efbe279580856897b63cc9417a3e875e405
Date: 2023-10-12T16:59:43.701Z
Electron: 25.8.4
ElectronBuildId: 24154031
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.23560
  • OS Version:
OS: Windows_NT x64 10.0.23560

Getting [object Object] when clicking on Settings Sync is On

Steps to Reproduce:

  1. Turn on Settings Sync Insiders
  2. On gear, click on Settings Sync is On

Result: Quick Pick

Image

I dont see anything in the devtools...
@sandy081
Copy link
Member

@TylerLeonhardt Is this related to your recent NLS changes?

TylerLeonhardt added a commit that referenced this issue Oct 16, 2023
@TylerLeonhardt
Use .value since the type had changed from string to `ILocalizedS…
45f69db 
…tring`

Fixes #195518

regressed in #193544
@TylerLeonhardt TylerLeonhardt mentioned this issue Oct 16, 2023
Merged
TylerLeonhardt added a commit that referenced this issue Oct 16, 2023
@TylerLeonhardt
Use .value since the type had changed from string to `ILocalizedS…
3cdcf0a 
…tring` (#195709)

Fixes #195518

regressed in #193544
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Oct 16, 2023
@vscodenpa vscodenpa added this to the October 2023 milestone Oct 16, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 17, 2023
Alex0007 pushed a commit to Alex0007/vscode that referenced this issue Oct 26, 2023
@TylerLeonhardt @Alex0007
Use .value since the type had changed from string to `ILocalizedS…
a2ff345 
…tring` (microsoft#195709)

Fixes microsoft#195518

regressed in microsoft#193544
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
October 2023
Development

Successfully merging a pull request may close this issue.

Use .value since the type had changed from string to ILocalizedString microsoft/vscode
3 participants
@chrisdias @sandy081 @vscodenpa