Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings sync appears as first walkthrough step on fresh install #196773

Closed
daviddossett opened this issue Oct 27, 2023 · 7 comments
Closed

Settings sync appears as first walkthrough step on fresh install #196773

daviddossett opened this issue Oct 27, 2023 · 7 comments
Assignees
@bhavyaus
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
October 2023 Reco...

Comments

@daviddossett
Copy link
Contributor

I noticed this:

Image

I was surprised to see that I was landed on the second step of the walkthrough, and that settings sync was listed first.
@sandy081
Copy link
Member

I was surprised to see that I was landed on the second step of the walkthrough, and that settings sync was listed first.

Is not this a bug that user landed on second step instead of the first step?

@daviddossett
Copy link
Contributor Author

It sounds like the step ordering change was intentional, but this behavior of skipping step 1 is possibly a bug. @bhavyaus can confirm.

@sandy081 sandy081 added the candidate Issue identified as probable candidate for fixing in the next release label Nov 7, 2023
@sandy081
Copy link
Member

sandy081 commented Nov 7, 2023

I just noticed that the welcome page is jumping to the second step and settings sync step is not shown. IMO this is worse than before as it will reduce the number of people going to settings sync step. Hence tagging this as candidate.

@sandy081 sandy081 added this to the October 2023 Recovery 2 milestone Nov 7, 2023
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Nov 7, 2023
@chrmarti chrmarti removed the candidate Issue identified as probable candidate for fixing in the next release label Nov 9, 2023
@chrmarti chrmarti removed this from the October 2023 Recovery 2 milestone Nov 9, 2023
@sandy081
Copy link
Member

sandy081 commented Nov 9, 2023

I can reproduce it consistently. Here are steps:

  • Open VS Code Insiders using fresh user data dir and extensions dir
    🐛 Welcome page jumps to themes
Kapture.2023-11-09.at.09.20.45.mp4

@sandy081 sandy081 added the candidate Issue identified as probable candidate for fixing in the next release label Nov 9, 2023
@sandy081 sandy081 added this to the October 2023 Recovery 2 milestone Nov 9, 2023
sandy081 added a commit that referenced this issue Nov 9, 2023
@sandy081
fix #196773
e6a4c85
@sandy081 sandy081 mentioned this issue Nov 9, 2023
Merged
sandy081 added a commit that referenced this issue Nov 9, 2023
@sandy081
fix #196773 (#197808)
1a5daa3 
* fix #196773

* safer fix
@chrmarti chrmarti closed this as completed Nov 9, 2023
@chrmarti
Copy link
Collaborator

chrmarti commented Nov 9, 2023

Verified in 1.84.2 release candidate.

@sandy081
Copy link
Member

sandy081 commented Nov 9, 2023

@bhavyaus Seems like there is a timing issue. Settings status gets initialised from shared process that is at least 2-3s after workbench is opened. Hence settings sync option is not shown in the welcome view for a moment. During that time, welcome goes to the second step. Meanwhile state changes and settings sync step is enabled but it seems to be too late. As a safe and temporary fix, I have removed the when context on settings sync because, settings sync should be always initialised in product.

I would suggest for a proper fix in welcome component in insiders.

@chrmarti chrmarti added the verified Verification succeeded label Nov 9, 2023
@StefanXhunga
Copy link

Thank you for your support

@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bhavyaus bhavyaus

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
October 2023 Recovery 2
Development

No branches or pull requests
6 participants
@chrmarti @sandy081 @StefanXhunga @bhavyaus @daviddossett and others