Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated loading of resource requests for web extensions #199269

Closed
yiliang114 opened this issue Nov 28, 2023 · 6 comments
Closed

Repeated loading of resource requests for web extensions #199269

yiliang114 opened this issue Nov 28, 2023 · 6 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@yiliang114
Copy link
Contributor

Reproduction steps:

  1. Open vscode.dev
  2. Open devtools and search package
  3. When refreshing the page, you will find that there are some duplicate resource loads such as package.json or package.nls.xxx.json

bug111

Version: 1.84.2
Commit: 1a5daa3
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36
Embedder: vscode.dev

@TylerLeonhardt
Copy link
Member

When you say duplicates are you saying they are duplicates of the same package.json? Keep in mind we need to load once the the package.json AND the package.LOCALE.json of each extension.

@yiliang114
Copy link
Contributor Author

Yeah, it's the same file. For example, I search for keywords vscode-pull-request-github (provided that I have this extension installed), Many duplicate locale files with the same name will appear in the debug panel.

image
image

@sandy081
Copy link
Member

We rely on browser cache here as these requests set proper cache headers and browser serves them from cache. May be you have disabled the cache.

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Nov 29, 2023
@yiliang114
Copy link
Contributor Author

We rely on browser cache here as these requests set proper cache headers and browser serves them from cache. May be you have disabled the cache.

In fact, I did not disable the cache, and the same resource will indeed be requested repeatedly. However, it is also true that the browser's strong cache or negotiation cache will hit, so the actual impact on the loading speed may be very small.

What will have an impact is actually that in the network panel, many repeated requests are very unfavorable for resource search and problem investigation.

@sandy081
Copy link
Member

What will have an impact is actually that in the network panel, many repeated requests are very unfavorable for resource search and problem investigation.

That's true, but that does not mean an application client should cache request responses. It is error prone. For diagnosing you can also use filtering in the network tab.

@vscodenpa
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

5 participants