Don't see sparkle after running git add . on Windows

[gregvanl]

Testing #199197

Works on macOS but not on Windows 11

[meganrogge]

Works for me on Windows 11. 👀 at the lack of command start decoration on the following line in the screenshot where this doesn't work.

[meganrogge]

Logs from @gregvanl:

2023-11-28 10:33:36.205 [info] Latency measurements for local backend
window<->ptyhost (message port): 19.50ms
window<->ptyhostservice<->ptyhost: 61.20ms
ptyhostservice<->ptyhost: 4.14ms []
2023-11-28 12:28:38.801 [debug] sending data "g" [[103]]
2023-11-28 12:28:38.830 [debug] parsing data "[?25l[93mg[97m[2m[3mit status[18;45H[?25h" [[27,91,63,50,53,108,27,91,57,51,109,103,27,91,57,55,109,27,91,50,109,27,91,51,109,105,116,32,115,116,97,116,117,115,27,91,49,56,59,52,53,72,27,91,63,50,53,104]]
2023-11-28 12:28:38.845 [debug] parsing data "[m" [[27,91,109]]
2023-11-28 12:28:38.887 [debug] sending data "i" [[105]]
2023-11-28 12:28:38.924 [debug] parsing data "[?25l[93mgi[97m[2m[3mt status[18;46H[?25h" [[27,91,63,50,53,108,27,91,57,51,109,8,103,105,27,91,57,55,109,27,91,50,109,27,91,51,109,116,32,115,116,97,116,117,115,27,91,49,56,59,52,54,72,27,91,63,50,53,104]]
2023-11-28 12:28:38.943 [debug] parsing data "[m" [[27,91,109]]
2023-11-28 12:28:39.002 [debug] sending data "t" [[116]]
2023-11-28 12:28:39.034 [debug] parsing data "[?25l[93m[18;44Hgit[97m[2m[3m status[18;47H[?25h" [[27,91,63,50,53,108,27,91,57,51,109,27,91,49,56,59,52,52,72,103,105,116,27,91,57,55,109,27,91,50,109,27,91,51,109,32,115,116,97,116,117,115,27,91,49,56,59,52,55,72,27,91,63,50,53,104]]
2023-11-28 12:28:39.052 [debug] parsing data "[m" [[27,91,109]]
2023-11-28 12:28:39.133 [debug] sending data " " [[32]]
2023-11-28 12:28:39.173 [debug] parsing data "[?25l[93m[18;44Hgit [97m[2m[3mstatus[18;48H[?25h" [[27,91,63,50,53,108,27,91,57,51,109,27,91,49,56,59,52,52,72,103,105,116,32,27,91,57,55,109,27,91,50,109,27,91,51,109,115,116,97,116,117,115,27,91,49,56,59,52,56,72,27,91,63,50,53,104]]
2023-11-28 12:28:39.190 [debug] parsing data "[m" [[27,91,109]]
2023-11-28 12:28:40.007 [debug] sending data "a" [[97]]
2023-11-28 12:28:40.038 [debug] parsing data "[?25l[93m[18;44Hgit [ma[97m[2m[3mdd .[m [18;49H[?25h" [[27,91,63,50,53,108,27,91,57,51,109,27,91,49,56,59,52,52,72,103,105,116,32,27,91,109,97,27,91,57,55,109,27,91,50,109,27,91,51,109,100,100,32,46,27,91,109,32,27,91,49,56,59,52,57,72,27,91,63,50,53,104]]
2023-11-28 12:28:40.299 [debug] sending data "d" [[100]]
2023-11-28 12:28:40.334 [debug] parsing data "[?25l[93m[18;44Hgit [mad[97m[2m[3md .[18;50H[?25h" [[27,91,63,50,53,108,27,91,57,51,109,27,91,49,56,59,52,52,72,103,105,116,32,27,91,109,97,100,27,91,57,55,109,27,91,50,109,27,91,51,109,100,32,46,27,91,49,56,59,53,48,72,27,91,63,50,53,104]]
2023-11-28 12:28:40.349 [debug] parsing data "[m" [[27,91,109]]
2023-11-28 12:28:40.464 [debug] sending data "d" [[100]]
2023-11-28 12:28:40.504 [debug] parsing data "[?25l[93m[18;44Hgit [madd[97m[2m[3m .[18;51H[?25h" [[27,91,63,50,53,108,27,91,57,51,109,27,91,49,56,59,52,52,72,103,105,116,32,27,91,109,97,100,100,27,91,57,55,109,27,91,50,109,27,91,51,109,32,46,27,91,49,56,59,53,49,72,27,91,63,50,53,104]]
2023-11-28 12:28:40.521 [debug] parsing data "[m" [[27,91,109]]
2023-11-28 12:28:40.629 [debug] sending data " " [[32]]
2023-11-28 12:28:40.659 [debug] parsing data "[?25l[93m[18;44Hgit [madd [97m[2m[3m.[?25h" [[27,91,63,50,53,108,27,91,57,51,109,27,91,49,56,59,52,52,72,103,105,116,32,27,91,109,97,100,100,32,27,91,57,55,109,27,91,50,109,27,91,51,109,46,8,27,91,63,50,53,104]]
2023-11-28 12:28:40.675 [debug] parsing data "[m" [[27,91,109]]
2023-11-28 12:28:40.860 [debug] sending data "." [[46]]
2023-11-28 12:28:40.892 [debug] parsing data "[?25l[93m[18;44Hgit [madd .[97m[2m[3m\blah.md[18;53H[?25h" [[27,91,63,50,53,108,27,91,57,51,109,27,91,49,56,59,52,52,72,103,105,116,32,27,91,109,97,100,100,32,46,27,91,57,55,109,27,91,50,109,27,91,51,109,92,98,108,97,104,46,109,100,27,91,49,56,59,53,51,72,27,91,63,50,53,104]]
2023-11-28 12:28:40.907 [debug] parsing data "[m" [[27,91,109]]
2023-11-28 12:28:41.916 [debug] sending data "
" [[13]]
2023-11-28 12:28:41.965 [debug] parsing data "[K]633;C" [[27,91,75,27,93,54,51,51,59,67,7]]
2023-11-28 12:28:41.966 [debug] CommandDetectionCapability#_handleCommandStartWindows [0,90]
2023-11-28 12:28:41.966 [debug] CommandDetectionCapability#_handleCommandStartWindows [0,90]
2023-11-28 12:28:41.967 [debug] CommandDetectionCapability#handleCommandExecuted [52,null]
2023-11-28 12:28:41.980 [debug] parsing data "
" [[13,10]]
2023-11-28 12:28:42.101 [debug] parsing data "]633;E;git add .;9a0bd256-de1b-433b-be1e-974c875b7f07]633;D;0]633;A]633;P;Cwd=C:\x5cUsers\x5cgregvanl\x5cdeleteMe\x5cTermTesting]633;B" [[27,93,54,51,51,59,69,59,103,105,116,32,97,100,100,32,46,59,57,97,48,98,100,50,53,54,45,100,101,49,98,45,52,51,51,98,45,98,101,49,101,45,57,55,52,99,56,55,53,98,55,102,48,55,7,27,93,54,51,51,59,68,59,48,7,27,93,54,51,51,59,65,7,27,93,54,51,51,59,80,59,67,119,100,61,67,58,92,120,53,99,85,115,101,114,115,92,120,53,99,103,114,101,103,118,97,110,108,92,120,53,99,100,101,108,101,116,101,77,101,92,120,53,99,84,101,114,109,84,101,115,116,105,110,103,7,27,93,54,51,51,59,66,7]]
2023-11-28 12:28:42.101 [debug] CommandDetectionCapability#setCommandLine ["git add .",true]
2023-11-28 12:28:42.102 [debug] CommandDetectionCapability#handleCommandFinished 0,,git add .,[object Object]
2023-11-28 12:28:42.103 [debug] CommandDetectionCapability#handlePromptStart [0,91]
2023-11-28 12:28:42.117 [debug] parsing data "PS C:\Users\gregvanl\deleteMe\TermTesting> " [[80,83,32,67,58,92,85,115,101,114,115,92,103,114,101,103,118,97,110,108,92,100,101,108,101,116,101,77,101,92,84,101,114,109,84,101,115,116,105,110,103,62,32]]
2023-11-28 12:28:42.154 [debug] CommandDetectionCapability#onCommandFinished [object Object]

[meganrogge]

onCommandFinished is happening after the next handlePromptStart in the above, which is pretty weird. We try to detect quick fixes onCommandFinished, so it's not surprising this is failing. @Tyriar any thoughts?

[Tyriar]

I likely caused this when making command markers more reliable on Windows

[meganrogge]

Seems this is broken for the non-polling case, which is why I am not seeing it (with starship).