Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Python SI prompt adjustment on Windows #199770

Closed
Tyriar opened this issue Dec 1, 2023 · 3 comments
Closed

Improve Python SI prompt adjustment on Windows #199770

Tyriar opened this issue Dec 1, 2023 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality terminal-shell-integration Shell integration, command decorations, etc. windows VS Code on Windows issues

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 1, 2023

Also tracking the prompt >>> will help a lot with the default python setup, now that it's landing in the extension.

@anthonykim1
Copy link
Contributor

anthonykim1 commented Jan 17, 2024

Attempted to fix by defining Python prompt

		const pythonPrompt = lineText.match(/^(?<prompt>>>> )/g)?.groups?.prompt;
		if (pythonPrompt) {
			return {
				prompt: pythonPrompt,
				likelySingleLine: true
			};
		}

in vscode's commandDetectionCapability, but still getting colorless bubbles.

Opting into windows heuristic from the Python extension side via

is_windows="\x1b]633;P;IsWindows=True\x07",

as well as defining Python prompt seemed to set the decoration in less randomized location, but still getting colorless decoration for Windows pwsh users.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 22, 2024

@anthonykim1 planning on this for March?

@anthonykim1
Copy link
Contributor

@Tyriar Actually this has been merged already: https://github.com/microsoft/vscode/pull/204513/files
Sorry I forgot to link this one.

@anthonykim1 anthonykim1 removed this from the March 2024 milestone Mar 23, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality terminal-shell-integration Shell integration, command decorations, etc. windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

3 participants