-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support other shell types for terminal shell integration history #155530
Comments
@Tyriar I've submitted a PR for |
Should probably reopen this, considering that #156058 only supports fish. |
Closing again, here's the current state:
Generally new shells should be handled in extensions or manual scripts unless it hits some critical mass where it's justified to build in support for VS Code. |
Julia commands are now properly inserted into the history (and persisted across terminal restarts), but it looks like recent commands are not looked up based on the current shell (which means my zsh and julia commands are mixed together). Is that working as intended? |
Doh, I read the issue wrong you're right 🤦 This does need to happen still and we'll run into this very soon with the upcoming Python integration. cc @anthonykim1 |
Yessss! I this would be awesome for run recent command microsoft/vscode-python#22647 which should happen in January after I make changes for #199770 as advised. (red/blue decorations are everywhere with Windows pwsh users when trying to use shell integration for Python REPL) |
@jooyoungseo here is where we're tracking this issue that you're eagerly awaiting 😄 . |
@anthonykim1 planning on this for March? |
@Tyriar I have a PR open, but did not have a room to finish this month. Will try to get this onto the plan next month! |
Closing this as completed since Julia, Nushell, Python is merged. |
@anthonykim1 since the work happened in August just adding verified it a nicer way to track things without losing the milestone info. |
Currently only pwsh, bash and zsh shell types are allowed to restore and fetch history for shell integration:
vscode/src/vs/workbench/contrib/terminal/common/history.ts
Lines 82 to 94 in 8846ac5
This needs to be more flexible to support other REPLs like fish, julia, python, etc.
The text was updated successfully, but these errors were encountered: