Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nushell as shell type in core #224326

Closed
anthonykim1 opened this issue Jul 30, 2024 · 1 comment · Fixed by #225335
Closed

Add Nushell as shell type in core #224326

anthonykim1 opened this issue Jul 30, 2024 · 1 comment · Fixed by #225335
Assignees
@anthonykim1
Labels
insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2024

Comments

@anthonykim1
Copy link
Contributor

Part of: #155530
This should allow clear separation when users attempt to "Terminal: Run Recent Command", as in only nu shell commands will show when in nu terminal.
@anthonykim1 anthonykim1 added the terminal-shell-integration Shell integration, command decorations, etc. label Jul 30, 2024
@anthonykim1 anthonykim1 added this to the August 2024 milestone Jul 30, 2024
@anthonykim1 anthonykim1 self-assigned this Jul 30, 2024
@anthonykim1 anthonykim1 changed the title Add nu as shell type in core Add Nu as shell type in core Jul 30, 2024
@anthonykim1 anthonykim1 changed the title Add Nu as shell type in core Add NuShell as shell type in core Jul 30, 2024
@anthonykim1 anthonykim1 changed the title Add NuShell as shell type in core Add Nushell as shell type in core Jul 30, 2024
@kieferrm kieferrm mentioned this issue Aug 4, 2024
Closed
44 tasks
@anthonykim1 anthonykim1 mentioned this issue Aug 10, 2024
Merged
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2024
@anthonykim1 anthonykim1 added the verification-needed Verification of issue is requested label Aug 26, 2024
@anthonykim1
Copy link
Contributor Author

Verification Steps:

  1. Install nushell and the
Screenshot 2024-08-26 at 3 12 25 PM
  1. type 'nu' in your terminal to launch nushell, then type some nu commands
  2. Open command palette (ctrl/cmd + shift +p) and run Terminal: Run Recent Command
  3. Observe you only see commands you typed in nushell in the tab and no commands from other shell.

@anthonykim1 anthonykim1 mentioned this issue Aug 26, 2024
Closed
@dbaeumer dbaeumer added the verified Verification succeeded label Aug 28, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anthonykim1 anthonykim1

Labels
insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2024
Development

Successfully merging a pull request may close this issue.

Add NuShell to core and separate out pwsh, python, julia, nu as GeneralShellType anthonykim1/vscode
2 participants
@dbaeumer @anthonykim1