Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia as a shell type in core #224325

Open
anthonykim1 opened this issue Jul 30, 2024 · 4 comments · Fixed by #225083
Open

Add Julia as a shell type in core #224325

anthonykim1 opened this issue Jul 30, 2024 · 4 comments · Fixed by #225083
Assignees
Labels
terminal-shell-integration Shell integration, command decorations, etc. verification-needed Verification of issue is requested
Milestone

Comments

@anthonykim1
Copy link
Contributor

Part of: #155530
This should allow clear separation when users attempt to "Terminal: Run Recent Command", as in Julia users will only see Julia commands from VS Code and not those from other shells.

@anthonykim1 anthonykim1 added the terminal-shell-integration Shell integration, command decorations, etc. label Jul 30, 2024
@anthonykim1 anthonykim1 added this to the August 2024 milestone Jul 30, 2024
@anthonykim1 anthonykim1 self-assigned this Jul 30, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2024
@anthonykim1 anthonykim1 added the verification-needed Verification of issue is requested label Aug 26, 2024
@anthonykim1
Copy link
Contributor Author

Verification Steps:

  1. Install and Julia and
Screenshot 2024-08-26 at 3 18 32 PM 2. Head over to command palette (launch via ctrl/cmd + shift + p) and press on Julia: Start REPL or Julia: Restart REPL Screenshot 2024-08-26 at 3 19 11 PM 3. Type in some Julia command in Terminal 4. Open command palette again and click on "Terminal: Run Recent Command" 5. Observe you only see command from Julia shell and no commands from other shell.

@amunger
Copy link
Contributor

amunger commented Aug 28, 2024

the Terminal: Run recent command command just no-ops for me if I have a Julia REPL running, even after running commands in there. I don't see any errors in the dev tools.

Recording 2024-08-28 at 10 03 03

@amunger amunger reopened this Aug 28, 2024
@amunger amunger removed the verified Verification succeeded label Aug 28, 2024
@vs-code-engineering vs-code-engineering bot removed the insiders-released Patch has been released in VS Code Insiders label Aug 28, 2024
@anthonykim1
Copy link
Contributor Author

@amunger What is exact name of the julia executable in your windows machine? Is it something that deviates from "julia.exe"?

@amunger
Copy link
Contributor

amunger commented Sep 3, 2024

from julia logs, it looks like it is using "julia.exe"

Trying to locate Julia binary...
Juliaup not found, locating Julia by other means.
The identified Julia executable is "julia.exe" with args "".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal-shell-integration Shell integration, command decorations, etc. verification-needed Verification of issue is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants