Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make globally file and content search more intuitive #200095

Closed
Tsimopak opened this issue Dec 5, 2023 · 7 comments
Closed

Make globally file and content search more intuitive #200095

Tsimopak opened this issue Dec 5, 2023 · 7 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@Tsimopak
Copy link

Tsimopak commented Dec 5, 2023

I would suggest an option to refactor the globally file/content search to look more like the one in jetbrains:

image

As you can see, a new pop up is raised when searching, and you can see in a list wise all the results and a preview beneath it, I think that it's more intuitive in terms of UX file and the preview are close to each other and also the file name is marked better.

I wish to be able to switch to such UI, as an optional choice.

@andreamah
Copy link
Contributor

We try to have a context-based search in our Search Editor https://code.visualstudio.com/docs/editor/codebasics#_search-editor. Does that help?

@andreamah andreamah added the info-needed Issue requires more information from poster label Dec 6, 2023
@Tsimopak
Copy link
Author

Tsimopak commented Dec 6, 2023

Hi @andreamah thanks for your fast response.
I am familiar with that UI window, but it seems less intuitive, it just look like a tests results inside a textarea element, which is not rich in UI elements, but just a text.

If you would watch again the image I just sent, you could see that instead of a full page, only a pop up of the search field is raised up and it composed of two main sections: the search field in which you see a preview of 1 liner of the search result and besides that the file and below u can see a preview of the full file content and it's also a scrollable window.

I am using intensively both VSCode products and Jetbrains and I think that this approach is better I really hope you could discuss internally about that and see if it has some advantages.

There's an option in that popup to stick the results to one of the panes, in that sense, it looks really close to the default and only search window in VSCode.

I just want to emphasis that for searching files the UI looks neat! and is very similar to the one of Jetbrains:
image

I would love to have the same UI but for searching content, so it will be with full file preview and a summary in bullets as I described above.

@andreamah
Copy link
Contributor

https://code.visualstudio.com/updates/v1_82#_quick-access-text-search Does something like this look a bit closer to what you want to see? We have an issue here to track the ability to see context in files live #191259

@Tsimopak
Copy link
Author

Tsimopak commented Dec 8, 2023

@andreamah Yeah it does! maybe adding a file preview below would be good as well! since sometimes it's hard to know from 1 line the context! Could this radar be an enhancement / feature request for that?

@andreamah
Copy link
Contributor

When this #191259 issue is implemented, you should be able to see the context (sort of like like what you see when you ctrl+shift+o on a file with symbols that you can navigate).

@Tsimopak
Copy link
Author

Tsimopak commented Dec 9, 2023

@andreamah Looking forward for that feature to be implemented! :D thank you for your answer.
But as far as I understand, this new context window wouldn't include a mini preview of that file, right? instead, every search result selection would navigate to that file on that specific place, wouldn't it be better to have the ability now to move to the entire file but instead see a snapshot in a small window? in that way you wouldn't lose track of your current file

@Tsimopak
Copy link
Author

Closing this issue, as it related to #203885

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants