Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement preview and code on highlighting in quick search panel #203885

Closed
Tsimopak opened this issue Jan 31, 2024 · 2 comments
Closed

Implement preview and code on highlighting in quick search panel #203885

Tsimopak opened this issue Jan 31, 2024 · 2 comments
Assignees

Comments

@Tsimopak
Copy link

When searching for something in the quick search panel, you would see it in uniform color except the pattern text:
image

The suggestion is to highlight it to the real colors it would have been colored if I would open the file, so for example variables in a certain color, string in other color and so on.

And the second idea is to be able to see +- X lines before and after, just to feel more the context of what search result I am looking at. Or just when moving between search results it would open it in watch mode, for a fast access, and when pressing ESC, it would return to the original file I was.

@TylerLeonhardt
Copy link
Member

In the latest VS Code you can see preview now:

Screen.Recording.2024-02-02.at.2.58.14.PM.mov

since we have this, I think that my eyes focus a lot on the editor and less the quick pick... so I don't think the code highlighting in the quick pick is needed. Additionally, that'd be quite a lot of work since we don't have a concept of code highlighting there.

Give the preview stuff a try and let us know if you find any issues with it!

@TylerLeonhardt TylerLeonhardt closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
@TylerLeonhardt
Copy link
Member

cc @andreamah

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants