Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aux Window: Full screen Terminal Window Input Lag #200469

Closed
maharshivpatel opened this issue Dec 10, 2023 · 5 comments · Fixed by xtermjs/xterm.js#4912 or #200999
Closed

Aux Window: Full screen Terminal Window Input Lag #200469

maharshivpatel opened this issue Dec 10, 2023 · 5 comments · Fixed by xtermjs/xterm.js#4912 or #200999
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Milestone
December / Januar...

Comments

@maharshivpatel
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: Version: 1.85.0 (Universal)
OS Version: Darwin arm64 22.5.0

Terminal input doesn't work ( is too slow almost feels like not working ) when using Full Screen in Aux Window.

Steps to Reproduce:

Open Aux Terminal Window In Full Screen Mode or make it Full screen afterwords.

Aux.Window.Full.Screen.mov
@maharshivpatel
Copy link
Author

This seems to be working in OSS Dev container.

@bpasero bpasero added workbench-auxwindow Issues related to use of auxiliary ("floating") windows. terminal Integrated terminal issues labels Dec 11, 2023
@bpasero
Copy link
Member

bpasero commented Dec 11, 2023

This looks to me like a case of scheduling something on the main window which gets throttled once hidden.

@Tyriar is the terminal using scheduler for rendering such as RAF or runWhenIdle?

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member labels Dec 11, 2023
@bpasero
Copy link
Member

bpasero commented Dec 11, 2023

I can reproduce and its pretty bad.

@maharshivpatel
Copy link
Author

off-topic: is there a way to move panel to separate window. e.g. bottom drawer or individually like terminal, debug console ?

jeanp413 added a commit to jeanp413/xterm.js that referenced this issue Dec 12, 2023
@jeanp413
Fixes microsoft/vscode#200469
54608bf
@jeanp413 jeanp413 mentioned this issue Dec 12, 2023
Merged
@jeanp413
Copy link
Contributor

PR fixing it xtermjs/xterm.js#4912

@Tyriar Tyriar added this to the December / January 2024 milestone Dec 15, 2023
@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream upstream-issue-fixed The underlying upstream issue has been fixed labels Dec 15, 2023
@Tyriar Tyriar reopened this Dec 15, 2023
Tyriar added a commit that referenced this issue Dec 15, 2023
@Tyriar
Update xterm
677f2ba 
Fixes #200469
@Tyriar Tyriar mentioned this issue Dec 15, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 15, 2023
@jeanp413 jeanp413 mentioned this issue Dec 18, 2023
Closed
@amunger amunger added the verified Verification succeeded label Jan 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded workbench-auxwindow Issues related to use of auxiliary ("floating") windows.
Projects
None yet
Milestone
December / January 2024
Development

Successfully merging a pull request may close this issue.

Fixes vscode #200469 jeanp413/xterm.js
Update xterm microsoft/vscode
8 participants
@bpasero @amunger @Tyriar @jeanp413 @meganrogge @maharshivpatel @aiday-mar @vscodenpa