Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.85.0 regressed our C/C++ extension's edtior.wordBasedSuggestions set in "configurationDefaults" and no migration is applied #200685

Open
sean-mcmanus opened this issue Dec 12, 2023 · 2 comments
Assignees

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Dec 12, 2023

Does this issue occur when all extensions are disabled?: N/A (requires an extension).

  • VS Code Version: 1.85.0
  • OS Version: Any

Steps to Reproduce:

  1. Use our C/C++ extension or see the PR at https://github.com/microsoft/vscode-cpptools/pull/11773/files
  2. Type "namespace f" in a .cpp file and see that the editor.wordBasedSuggestion false is not being applied (it worked in 1.84.0).

Expected: There should be some automatic "migration" code that is automatically applied to extension's settings like is done for user-set settings.

The change was caused by #197690 .

@hediet
Copy link
Member

hediet commented Dec 18, 2023

@alexr00 do you know if sth changed here?

@alexr00 alexr00 assigned Yoyokrazy and unassigned alexr00 and hediet Dec 18, 2023
@alexr00
Copy link
Member

alexr00 commented Dec 18, 2023

C++ grammar has been frozen for a while.

@sean-mcmanus thanks for including your root causing to #197690!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants