Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge x-doc and occurrence setting, merge word based suggestion settings #197690

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Merge x-doc and occurrence setting, merge word based suggestion settings #197690

merged 4 commits into from
Nov 10, 2023

Conversation

Yoyokrazy
Copy link
Contributor

Fixes: #196353

This mirrors the approach of word based suggestions and the associated settings there. No behavior changes at all with this, just much improved readability and the behavior more closely aligns with the setting descriptions/names.

Can also tweak and merge the settings into a single setting with multiple accepted value sets (ie boolean | enum), though to some effect I think that may reduce discoverability.

@Yoyokrazy Yoyokrazy self-assigned this Nov 7, 2023
@Yoyokrazy Yoyokrazy changed the title Change Change setting name of multi-document occurrence highlighting Nov 7, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the November 2023 milestone Nov 7, 2023
@Yoyokrazy Yoyokrazy mentioned this pull request Nov 7, 2023
Closed
@Yoyokrazy Yoyokrazy changed the title Change setting name of multi-document occurrence highlighting Merge x-doc and occurrence setting, merge word based suggestion settings Nov 10, 2023
@Yoyokrazy Yoyokrazy merged commit 6f2f46e into main Nov 10, 2023
6 checks passed
@Yoyokrazy Yoyokrazy deleted the influential-junglefowl branch November 10, 2023 21:17
@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Dec 12, 2023 •
edited
Loading

@Yoyokrazy This PR breaks our extension's default settings -- what is the recommended way for us to handle this? There doesn't appear to be any migration or compatibility in place for settings values set by extensions. I have PR at https://github.com/microsoft/vscode-cpptools/pull/11773/files that fixes it for 1.85.0, but that would regress old VS Code versions unless we increased our minimum supported VS Code version (causing users with 1.84.0 to not see our updates).

i.e. it appears that user settings have a migration/conversion in place, which isn't being run on the extension's "configurationDefaults" in package.json

I created a bug report at #200685 .

This was referenced Dec 12, 2023
Merged
Open
hrishikesh-kadam added a commit to hrishikesh-kadam/dart-flutter-vscode-extension that referenced this pull request Dec 13, 2023
@hrishikesh-kadam
Update editor.wordBasedSuggestions for VS Code 1.85.0
1243bcf 
References:
- microsoft/vscode#197690
- https://github.com/microsoft/vscode/blob/f06dad8535e4556e97734a83a2eac83ca23af8eb/src/vs/editor/common/config/editorConfigurationSchema.ts#L64-L74
@hrishikesh-kadam hrishikesh-kadam mentioned this pull request Dec 13, 2023
Merged
hrishikesh-kadam added a commit to hrishikesh-kadam/dart-flutter-vscode-extension-website that referenced this pull request Dec 13, 2023
@hrishikesh-kadam
Update editor.wordBasedSuggestions for VS Code 1.85.0
a084b4b 
References:
- Dart-Code/Dart-Code#4897
- microsoft/vscode#197690
- https://github.com/microsoft/vscode/blob/f06dad8535e4556e97734a83a2eac83ca23af8eb/src/vs/editor/common/config/editorConfigurationSchema.ts#L64-L74
@hrishikesh-kadam hrishikesh-kadam mentioned this pull request Dec 13, 2023
Merged
DanTup pushed a commit to Dart-Code/Website that referenced this pull request Dec 13, 2023
@hrishikesh-kadam @DanTup
Update editor.wordBasedSuggestions for VS Code 1.85.0
9a1eb12 
References:
- Dart-Code/Dart-Code#4897
- microsoft/vscode#197690
- https://github.com/microsoft/vscode/blob/f06dad8535e4556e97734a83a2eac83ca23af8eb/src/vs/editor/common/config/editorConfigurationSchema.ts#L64-L74
DanTup pushed a commit to Dart-Code/Dart-Code that referenced this pull request Dec 13, 2023
@hrishikesh-kadam @DanTup
Update editor.wordBasedSuggestions for VS Code 1.85.0
76473dc 
References:
- microsoft/vscode#197690
- https://github.com/microsoft/vscode/blob/f06dad8535e4556e97734a83a2eac83ca23af8eb/src/vs/editor/common/config/editorConfigurationSchema.ts#L64-L74
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

@jrieken jrieken Awaiting requested review from jrieken

Assignees

@Yoyokrazy Yoyokrazy

Labels
None yet
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.

Merge editor.occurrencesHighlight and editor.multiDocumentOccurrencesHighlight setting
5 participants
@Yoyokrazy @sean-mcmanus @rebornix @jrieken @VSCodeTriageBot