Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Folder Opened Translation is lost. #202390

Closed
yiliang114 opened this issue Jan 9, 2024 · 6 comments
Closed

No Folder Opened Translation is lost. #202390

yiliang114 opened this issue Jan 9, 2024 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Milestone

Comments

@yiliang114
Copy link
Contributor

yiliang114 commented Jan 9, 2024

image

Reproduction steps:

  1. Open https://insiders.vscode.dev/
  2. Switch zh-cn or any other language except English.
  3. Focus explorer tree view title

Version: 1.86.0-insider
Commit: fb76955
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36
Embedder: vscode.dev

@csigs
Copy link
Member

csigs commented Jan 9, 2024

Thank you for your feedback. We are currently reviewing it (reference 936226).

@cristianosuzuki77
Copy link

@TylerLeonhardt would you help us locate this resource?

@TylerLeonhardt
Copy link
Member

Looks like it's not being exported...

It's clearly marked:

static readonly NAME: ILocalizedString = nls.localize2('noWorkspace', "No Folder Opened");

It's the only string in the file and it's only using localize2 I wonder if my logic for extracting strings has a bug in it where it's not picking up this case...

@TylerLeonhardt TylerLeonhardt transferred this issue from microsoft/vscode-loc Jan 13, 2024
@TylerLeonhardt TylerLeonhardt self-assigned this Jan 13, 2024
@TylerLeonhardt TylerLeonhardt added l10n-platform Localization platform issues (not wrong translations) bug Issue identified by VS Code Team member as probable bug labels Jan 13, 2024
@TylerLeonhardt TylerLeonhardt added this to the February 2024 milestone Jan 13, 2024
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Feb 1, 2024

I think @mjbvz fixed this in #203851

if (localizeCalls.length === 0) {

into

if (localizeCalls.length === 0 && localize2Calls.length === 0) {

I do see it being exported now so this should be fixed within the month as this string goes through the localization pipeline. Closing for verification at the end of the month.

@rzhao271 rzhao271 added the verified Verification succeeded label Feb 21, 2024
@rzhao271
Copy link
Contributor

The translation is not in yet. Should we move this to March?

@rzhao271 rzhao271 added verification-found Issue verification failed and removed verified Verification succeeded labels Feb 21, 2024
@TylerLeonhardt TylerLeonhardt removed the verification-found Issue verification failed label Feb 21, 2024
@TylerLeonhardt
Copy link
Member

Yes I don't think we got a language pack release last month due to some pipeline issues so we should see the fix next month.

@mjbvz mjbvz added the verified Verification succeeded label Mar 25, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants