Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nls build script on line such as localize2(...) ... localize(...) #203851

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Jan 31, 2024

For #203842

I believe we need to apply the patches in character order. Otherwise the line ends up corrupted after the patching

For microsoft#203842

I believe we need to apply the patches in character order. Otherwise the line ends up corrupted after the patching
@mjbvz mjbvz self-assigned this Jan 31, 2024
@mjbvz mjbvz enabled auto-merge (squash) January 31, 2024 00:25
@vscodenpa vscodenpa added this to the February 2024 milestone Jan 31, 2024
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Thanks for fixing this!

@mjbvz mjbvz merged commit 0404d17 into microsoft:main Jan 31, 2024
6 checks passed
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants