Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Electron 28 update #205519

Closed
3 tasks done
deepak1556 opened this issue Feb 19, 2024 · 1 comment
Closed
3 tasks done

Test: Electron 28 update #205519

deepak1556 opened this issue Feb 19, 2024 · 1 comment

Comments

@deepak1556
Copy link
Collaborator

deepak1556 commented Feb 19, 2024

Refs: #201935

Complexity: 3

Create Issue


We plan to promote Electron 28 in the March 2024 milestone to insiders. The following tests cover some of the common UI bits that don't have smoke tests. You can download the nightly explorations builds from here for testing.

Testing:

  • macOS:

    • Enable Native Tabs (via settings: window.nativeTabs: true)
      • Ensure native tabs are enabled in the system preferences (System Preferences > General > Prefer tabs: "always":)
      • Launch application
      • Try opening new window from either command line (code-exploration ) or from the menu entry (Cmd + Shift + N)
      • Verify new window is launched as a new tab in the active instance of the application window is focused when starting from command line
      • open the code exploration application from finder or dock
      • open external terminal
      • run code-exploration
      • make sure the new window is put to foreground
  • windows:

    • verify maximize and restore operations work as expected when OS task bar is auto-hidden for custom titlebar
    • Verify titlebar is not clipped off when exiting fullscreen
      • Maximize VS Code window
      • Press F11 or Ctrl+K Z twice to enter/exit full screen.
      • Verify titlebar is not cropped
    • Verify there is no rendering lag with custom titlebar
  • All OS:

    • Check out the electron-28.x.y branch locally and verify you can run out of sources, set a breakpoint and debug using the VS Code launch configurations and VS Code debugger
@deepak1556 deepak1556 added this to the February 2024 milestone Feb 19, 2024
@rebornix rebornix removed their assignment Feb 20, 2024
@rzhao271
Copy link
Contributor

rzhao271 commented Feb 20, 2024

My Ubuntu 22.04 VM keeps freezing while running yarn watch. I'll have to see whether Insiders has the same issue for me on the VM.

Edit: Insiders has the same issue for me. I haven't noticed any other issues other than being unable to build and debug OSS. I can try building and running an extension.

Edit 2: I have confirmed I can build and debug a VS Code extension on Exploration on my Ubuntu 22.04 VM. Feel free to add another Zurich Linux tester if someone has a more powerful Linux machine.

Edit 3: I have verified the TPI on my personal device.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants