Update to Electron 28

[verhovsky]

Electron 28 was released on December 5th, 2023. It finally supports ECMAScript Modules (ESM) https://www.electronjs.org/docs/latest/tutorial/esm which I would like to use in my VS Code extension.

@deepak1556 could you update Electron again please?

[deepak1556]

Todo

• Update patches
• Update native modules
• Nightly Exploration builds
• Update/Check LICENSE file in CG for new node.js version
• Update LICENSE for new ffmpeg version

[C0rn3j]

I would like to note that Electron 28 seemingly fixes some crashing issues on Wayland electron/electron#37531 (comment)

I have a hope it might, at least partially, resolve #184124 / electron/electron#39449.

Wasn't sure in which one of the three threads to link it, hope this is fine

EDIT: Actually this will also make VSC respect the ELECTRON_OZONE_PLATFORM_HINT env var so finally people will be able to shut up the pointless Warning: 'ozone-platform' is not in the list of known options, but still passed to Electron/Chromium. .

[fisforfaheem]

Kindly make sure to release this version with electron 28

[Manish3323]

🤩

[svipas]

@deepak1556 As I can see Electron 28 isn't released with 1.87.0, is it going to be included in 1.88.0?

Version: 1.87.0
Commit: 019f4d1419fbc8219a181fab7892ebccf7ee29a2
Date: 2024-02-27T23:42:51.279Z
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.87.0 Chrome/118.0.5993.159 Electron/27.3.2 Safari/537.36

[C0rn3j]

@svipas Feature targeted for March won't be present in a February build.

[deepak1556]

@svipas yes the update will be available in 1.88 release.

[AlexCannonball]

I've tested 1.88 on Windows with an extension using ESM import-s and it doesn't work. I get the following error upon the extension activation:

Activating extension 'xxxxxx' failed: require() of ES Module d:\xxxxxx\out\extension.js from d:\Programs\VS_code\resources\app\out\vs\loader.js not supported. Instead change the require of extension.js in d:\Programs\VS_code\resources\app\out\vs\loader.js to a dynamic import() which is available in all CommonJS modules..

#209560