Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge editor: TypeScript type errors do not appear #206672

Open
OliverJAsh opened this issue Mar 2, 2024 · 2 comments
Open

Merge editor: TypeScript type errors do not appear #206672

OliverJAsh opened this issue Mar 2, 2024 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug merge-editor typescript Typescript support issues
Milestone

Comments

@OliverJAsh
Copy link
Contributor

OliverJAsh commented Mar 2, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.87.0
  • OS Version: macOS 14.2.1 (23C71)

Steps to Reproduce:

Install TypeScript and create main.ts with contents:

export const add1 = (n: number) => n + 1;

add1(2)

Copy and apply the following patch e.g. using pbpaste | git apply -3. This will result in a conflict.

diff --git a/main.ts b/main.ts
index 4885bfc..bfd86b9 100644
--- a/main.ts
+++ b/main.ts
@@ -1,3 +1,4 @@
 export const add1 = (n: number) => n + 1;
 
+// foo
 add1(1)

Open the conflict in VS Code's merge editor.

Resolve the conflict but purposefully create a type error.

Expected: the type error should appear.

Actual: the type error does not appear. The type error only appears if I open the file outside of the merge editor.

Screen.Recording.2024-03-02.at.10.19.30.2.mov
@vscodenpa
Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.0. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@hediet
Copy link
Member

hediet commented Mar 4, 2024

@mjbvz it seems like diagnostics only update when the text document is opened in another editor:

Image

@hediet hediet added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues merge-editor labels Mar 4, 2024
@mjbvz mjbvz added this to the Backlog milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug merge-editor typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

4 participants