-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi diff text editor has no tab input #206411
Comments
When you listen for tab changes the input of the tab is currently |
Related: #206672 |
Thanks! |
Reopening to get API approval. I'm also not sure we will be able to expose the resources in multi diff @dbaeumer. This will probably complicate your use case. @hediet pointed out that the resources can change without changing the input and this is not something any of other inputs do making supporting showing the resources for this input quite difficult. |
@dbaeumer Can you verify? To verify please ensure that you see a type now for the multi diff text editor and it properly reacts to resource changes |
To be able to reach to the files presented in a multi diff text editor the tab model should provide a corresponding TabInput (see
vscode/src/vscode-dts/vscode.d.ts
Line 17714 in 6504145
May be a good idea would be to have a general composite tab input. For the multi diff text editor the elements could then be
TabInputTextDiff
The text was updated successfully, but these errors were encountered: