Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi diff text editor has no tab input #206411

Closed
dbaeumer opened this issue Feb 28, 2024 · 6 comments · Fixed by #207747 or #210094
Closed

Multi diff text editor has no tab input #206411

dbaeumer opened this issue Feb 28, 2024 · 6 comments · Fixed by #207747 or #210094
Assignees
Labels
api-proposal author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders multi-diff-editor Multi diff editor issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@dbaeumer
Copy link
Member

To be able to reach to the files presented in a multi diff text editor the tab model should provide a corresponding TabInput (see

export class TabInputTextDiff {
)

May be a good idea would be to have a general composite tab input. For the multi diff text editor the elements could then be TabInputTextDiff

@dbaeumer
Copy link
Member Author

When you listen for tab changes the input of the tab is currently undefined.

@dbaeumer
Copy link
Member Author

Not sure if this is @hediet or @lramos15

@hediet
Copy link
Member

hediet commented Mar 4, 2024

Related: #206672

@hediet hediet modified the milestones: Backlog, March 2024 Mar 4, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 14, 2024
@dbaeumer
Copy link
Member Author

Thanks!

@lramos15
Copy link
Member

Reopening to get API approval.

I'm also not sure we will be able to expose the resources in multi diff @dbaeumer. This will probably complicate your use case. @hediet pointed out that the resources can change without changing the input and this is not something any of other inputs do making supporting showing the resources for this input quite difficult.

@lramos15 lramos15 reopened this Mar 18, 2024
@vscodenpa vscodenpa removed the insiders-released Patch has been released in VS Code Insiders label Mar 18, 2024
@hediet hediet removed their assignment Mar 26, 2024
@lramos15 lramos15 modified the milestones: March 2024, April 2024 Mar 26, 2024
@aiday-mar aiday-mar assigned aiday-mar and unassigned aiday-mar Apr 8, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 11, 2024
@lramos15 lramos15 added the verification-needed Verification of issue is requested label Apr 22, 2024
@lramos15
Copy link
Member

@dbaeumer Can you verify?

To verify please ensure that you see a type now for the multi diff text editor and it properly reacts to resource changes

@benibenj benibenj added the author-verification-requested Issues potentially verifiable by issue author label Apr 23, 2024
@microsoft microsoft deleted a comment from vscodenpa Apr 23, 2024
@jrieken jrieken added the verified Verification succeeded label Apr 23, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-proposal author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders multi-diff-editor Multi diff editor issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
7 participants