Add listeners for multi diff tab editor #210094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hediet
approved these changes
Apr 11, 2024
|
What do you think is strange about it? |
|
The tab model has always been powered by broader editor service / editor group service events to listen to changes happening and construct a view of what the tab world looks like. This is the first case where we must now basically track a certain tab type and when it opens or closes as to subscribe to events on it. That causes a lot of odd instanceof type checks and an additional complexity to the listeners |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206411
A little strange that we need to listen to MultiDiffEditorInputs specifically as a sort of one off case, but maybe there will be others in the future