Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context menu to comments in comments panel to un/resolve conversation #206898

Open
benibenj opened this issue Feb 10, 2024 · 3 comments
Open

Add context menu to comments in comments panel to un/resolve conversation #206898

benibenj opened this issue Feb 10, 2024 · 3 comments
Assignees
@alexr00
Labels
api api-finalization feature-request Request for new features or functionality
Milestone
On Deck

Comments

@benibenj
Copy link
Contributor

It would be nice to be able to right click a comment in the comments panel to resolve it. This is especially useful when the file got deleted in which the comment is located.
@alexr00 alexr00 added the feature-request Request for new features or functionality label Feb 13, 2024
@kieferrm kieferrm mentioned this issue Mar 4, 2024
Closed
64 tasks
@alexr00 alexr00 transferred this issue from microsoft/vscode-pull-request-github Mar 5, 2024
@alexr00 alexr00 added this to the March 2024 milestone Mar 5, 2024
alexr00 added a commit that referenced this issue Mar 7, 2024
@alexr00
Add context menu to comments in comments panel to un/resolve conversa…
e2da9fe 
…tion

Part of #206898
@alexr00 alexr00 mentioned this issue Mar 7, 2024
Merged
@alexr00
Copy link
Member

alexr00 commented Mar 7, 2024

Proposed menu is commentsView/commentThread/context, with the usual inline group for showing inline actions vs. context menu actions.

@alexr00 alexr00 modified the milestones: March 2024, April 2024 Mar 7, 2024
@alexr00
Copy link
Member

alexr00 commented Mar 7, 2024

Moving to April to consider finalizing then.

alexr00 added a commit that referenced this issue Mar 7, 2024
@alexr00
Add context menu to comments in comments panel to un/resolve conversa…
1b9143d 
…tion (#207056)

Part of #206898
@AbuKram032012
Copy link

#206739 (comment)

@alexr00 alexr00 modified the milestones: April 2024, On Deck Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
api api-finalization feature-request Request for new features or functionality
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
3 participants
@alexr00 @benibenj @AbuKram032012