Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky scroll sets line-height for the sticky row even though I set setRowLineHeight: false in the ListOptions #207649

Closed
TylerLeonhardt opened this issue Mar 13, 2024 · 1 comment · Fixed by #207691
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders tree-sticky-scroll Sticky Scroll in Trees
Milestone

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Mar 13, 2024

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version:
  • OS Version:

Steps to Reproduce:

  1. See how this is set:
  2. See this:
    <div class="monaco-tree-sticky-row monaco-list-row focused" data-index="0" data-parity="even" id="list_id_3_0" role="option" aria-label="extensions.json, extensions.json" aria-selected="false" aria-expanded="true" style="top: 0px; height: 24px; line-height: 24px;">
    Notice the line height is set to 24px.

This causes my item to jiggle when I start scrolling:

Screen.Recording.2024-03-13.at.4.00.56.PM.mov

if I get rid of that line-height setting, the behavior works as expected. No jittering

stickyElement.style.lineHeight = `${stickyNode.height}px`;

@benibenj
Copy link
Contributor

Thanks for reporting, was unaware this existed. I now consider the setRowHeight and setRowLineHeight options

benibenj added a commit that referenced this issue Mar 14, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Mar 14, 2024
@vscodenpa vscodenpa added this to the March 2024 milestone Mar 14, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 15, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders tree-sticky-scroll Sticky Scroll in Trees
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants