Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split View does not account for 1px border #207977

Open
yiliang114 opened this issue Mar 18, 2024 · 1 comment
Open

Split View does not account for 1px border #207977

yiliang114 opened this issue Mar 18, 2024 · 1 comment
Assignees
@joaomoreno @benibenj
Labels
bug Issue identified by VS Code Team member as probable bug splitview-widget Splitview UI system issues

Comments

@yiliang114
Copy link
Contributor

Reproduction steps:

  1. Open https://vscode.dev/github/microsoft/vscode

  2. Open a file and use command Split Editor Right

  3. Look carefully at the dividing line of tab on the right.
    image

  4. The browser method can observe that the width of the border line is inconsistent when the first tab of the editor and the second tab are activated.
    image
    image

Version: 1.87.2
Commit: 863d258
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36
Embedder: vscode.dev
yiliang114 added a commit to yiliang114/vscode that referenced this issue Mar 18, 2024
@yiliang114
Fix microsoft#207977, multieditor tab border offset position when act…
6d25a42 
…ivated
@bpasero bpasero assigned benibenj and unassigned bpasero Mar 18, 2024
@bpasero bpasero added the workbench-tabs VS Code editor tab issues label Mar 18, 2024
@benibenj benibenj added grid-widget Grid view widget and removed workbench-tabs VS Code editor tab issues labels Mar 18, 2024
@benibenj benibenj added bug Issue identified by VS Code Team member as probable bug splitview-widget Splitview UI system issues and removed grid-widget Grid view widget labels Mar 18, 2024
@benibenj
Copy link
Contributor

benibenj commented Mar 18, 2024 •
edited
Loading

This seems to be a Split View problem which also appears on desktop. The second element in the Split View sets the border between the two views with absolute positioning and does not account for any margin. This means the border is insider the view range and hence the view can draw under and on top of it. @joaomoreno

image

@benibenj benibenj changed the title The tab split line is missing 1px in the split screen state. Split View does not account for 1px border Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaomoreno joaomoreno

@benibenj benibenj

Labels
bug Issue identified by VS Code Team member as probable bug splitview-widget Splitview UI system issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @yiliang114 @benibenj