Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Activity Bar Position Bottom (and Top) #208384

Closed
2 tasks done
benibenj opened this issue Mar 22, 2024 · 0 comments
Closed
2 tasks done

Test: Activity Bar Position Bottom (and Top) #208384

benibenj opened this issue Mar 22, 2024 · 0 comments

Comments

@benibenj
Copy link
Contributor

benibenj commented Mar 22, 2024

Refs: #118692

Complexity: 3

Create Issue


In this iteration we added support for moving the activity bar location to the bottom. While doing so we also made changes to the way the activity bar is rendered when placed at the top.

Testing:

  1. Open both primary and secondary side bar and make sure there is at least 1 view open in each.
  2. Set workbench.activityBar.location: "bottom"
  3. The activity bar should be moved to the bottom of both side bars
  4. Interact with the activity bar to make sure it works: Open different views and reorder them with drag and drop
  5. Make sure in the secondary side bar that there is a close button at the top right corner.
  6. Set workbench.activityBar.location: "top"
  7. The activity bar is now moved to the top of the side bar, above the title of the view/container.
  8. Interact with the activity bar to make sure it works: Open different views and reorder them with drag and drop
  9. Make sure in the secondary side bar that there is a close button at the top right corner.
@benibenj benibenj added this to the March 2024 milestone Mar 22, 2024
@ulugbekna ulugbekna removed their assignment Mar 25, 2024
@eleanorjboyd eleanorjboyd removed their assignment Mar 25, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants