Too many changes warning is too persistent and in the wrong place

[alexr00]

I checked-out an old commit from 7 years ago (a8c629d). The SCM view got stuck displaying the "busy" badge and showed many file changes, along with a warning about too many changes.

When I changed views, the warning stuck around even on top of other view containers. Eventually, it moved into the top right corner. The SCM view now appears to be permanently busy.

[lszomoru]

That does not look good. I am also able to reproduce in Stable so I believe that this was broken last milestone.
It's very easy to reproduce by setting git.statusLimit to 3 and then making changes to 4 files.

[lszomoru]

Adding @benibenj and @TylerLeonhardt to see if this rings a bell for them as the made changes to IContextViewService recently. Based on my tests, this worked fine in 1.87 but it's broken with 1.88. I stepped through the SCM code and it seems that no changes in execution there.

[TylerLeonhardt]

I didn't do any crazy changes there AFAIK, I feel like @benibenj was maybe more in there so could you take a look first?

[benibenj]

Found the culprit #207520. Fix it with #211219

[benibenj]

It turns out the fix actually breaks hovers entirely. @TylerLeonhardt you turned the disposable into a MutableDisposable which I believe does not work in this context. I think we should revert 09d9b06.

[TylerLeonhardt]

@benibenj I can drive reverting that commit but think this should be revisited in debt week as we have disposables there not getting disposed of.

[lszomoru]

Thank you @benibenj and @TylerLeonhardt.

[benibenj]

@TylerLeonhardt I had a closer look at the code. The concept of using disposables for this case was flawed from the start. I created a fix for it.

[TylerLeonhardt]

Thanks for doing that @benibenj!