make error/warning signal delay configurable

[meganrogge]

          A 1-second delay, in my opinion, does not significantly improve user experience. Ideally, this delay should be configurable, with a default setting of at least 3 seconds. setting `editor.hover.delay` is a viable workaround; however, it falls short in addressing the issue when an error or warning state has already been triggered.

Originally posted by @rperez030 in #204257 (comment)

[meganrogge]

vscode/src/vs/workbench/contrib/accessibilitySignals/browser/editorTextPropertySignalsContribution.ts

Line 166 in 9c7e863

private _getDelay(signal: AccessibilitySignal, modality: AccessibilityModality): number {

[meganrogge]

@jooyoungseo, @rperez030 do you have suggestions for the default delays when:

1. navigating between lines, error (currently 400ms for sound, 3000ms for announcement)
2. navigating between lines, warning (currently 400ms for sound, 3000ms for announcement)
3. navigating between positions, error (currently 100ms for sound, 1000ms for announcement)
4. navigating between positions, warning (currently 100ms for sound, 1000ms for announcement)

@hediet As settings, this could be represented like:

accessibility.signalOptions.errorDelays: {
    soundAtPosition:
    announcementAtPosition:
    soundAtLine:
    announcementAtLine:
}
accessibility.signalOptions.warningDelays: {
    soundAtPosition:
    announcementAtPosition:
    soundAtLine:
    announcementAtLine:
}

There are many other ways this could be represented though. WDYT?

[hediet]

There are many other ways this could be represented though. WDYT?

I like it! We should keep it open for future refactorings though. Thanks for implementing this!

Please implement this in the service and make every audio cue have these delay fields in the interface (though they might all come from the same setting).

[rperez030]

1. navigating between lines, error (currently 400ms for sound, 3000ms for announcement)

Good

2. navigating between lines, warning (currently 400ms for sound, 3000ms for announcement)

Good

3. navigating between positions, error (currently 100ms for sound, 1000ms for announcement)

1000ms for sound, 3000ms for announcement

4. navigating between positions, warning (currently 100ms for sound, 1000ms for announcement)

1000ms for sound, 3000ms for announcement

@meganrogge What about typing? Would that be equivalent to navigating between positions? It would be great to get additional feedback about these defaults.

[meganrogge]

@meganrogge What about typing? Would that be equivalent to navigating between positions?

Yes, exactly.

Agree re more feedback. If I merge this soon, then we can get feedback before it's released to stable.

[meganrogge]

@rperez030 I had misunderstood, here is the current status:

1. navigating between positions, error or warning (currently 100ms for sound, 1000ms for announcement)
2. navigating between lines, any signal (currently 400ms for sound, 3000ms for announcement)

So we should probably have

accessibility.signalOptions.delays: {
   general: {
    sound:, 
    announcement:,
   },
    warningAtPosition: {
    sound:
    announcement:
    },
   errorAtPosition: {
   sound:
   announcement:
    },
}