Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Editor Labels: Wrong directory for ${dirname} #211522

Closed
benibenj opened this issue Apr 27, 2024 · 1 comment · Fixed by #211523
Closed

Custom Editor Labels: Wrong directory for ${dirname} #211522

benibenj opened this issue Apr 27, 2024 · 1 comment · Fixed by #211523
Assignees
@benibenj
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
April 2024

Comments

@benibenj
Copy link
Contributor

benibenj commented Apr 27, 2024 •
edited
Loading

Example file: root/static/folder/file.txt

  • Expected: ${dirname} -> folder
  • Bug: ${dirname} -> static

Screenshot 2024-04-26 at 19 22 58
Screenshot 2024-04-26 at 19 23 12

Originally posted by @riungemaina in #41909 (comment)
@benibenj benibenj added the bug Issue identified by VS Code Team member as probable bug label Apr 27, 2024
@benibenj benibenj self-assigned this Apr 27, 2024
@benibenj benibenj mentioned this issue Apr 27, 2024
Open
@benibenj benibenj added this to the April 2024 milestone Apr 27, 2024
@benibenj benibenj added the candidate Issue identified as probable candidate for fixing in the next release label Apr 27, 2024
benibenj added a commit that referenced this issue Apr 27, 2024
@benibenj
fixes #211522
b056257
@benibenj benibenj mentioned this issue Apr 27, 2024
Merged
benibenj added a commit that referenced this issue Apr 27, 2024
@benibenj
fixes #211522
e89c96c
@benibenj benibenj mentioned this issue Apr 27, 2024
Merged
benibenj added a commit that referenced this issue Apr 28, 2024
@benibenj
Fix wrong directory for Custom Editor Labels (#211523)
ddf21a5 
* fixes #211522

* 💄
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Apr 28, 2024
@deepak1556 deepak1556 reopened this Apr 29, 2024
@vscodenpa vscodenpa removed the unreleased Patch has not yet been released in VS Code Insiders label Apr 29, 2024
@deepak1556
Copy link
Collaborator

Closing for verification.

@rzhao271 rzhao271 added the verified Verification succeeded label Apr 29, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 13, 2024
nang-dev pushed a commit to trypear/pearai-app that referenced this issue Oct 3, 2024
@benibenj
fixes microsoft#211522
0b4b4fe
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benibenj benibenj

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
April 2024
Development

Successfully merging a pull request may close this issue.

Fix wrong directory for Custom Editor Labels microsoft/vscode
4 participants
@deepak1556 @rzhao271 @benibenj @vscodenpa