Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications - show which extension they came from #21302

Closed
roblourens opened this issue Feb 23, 2017 · 9 comments
Closed

Notifications - show which extension they came from #21302

roblourens opened this issue Feb 23, 2017 · 9 comments
Assignees
Labels
api feature-request Request for new features or functionality ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Feb 23, 2017

Sometimes notification messages appear, and it isn't clear whether they are from vscode or an extension, and if so, which one. Right now I sometimes see "The internet connection appears to be offline" and don't know which extension is responsible. It would be useful to be able to easily trace the message to an extension, maybe with a tooltip on the message that shows the originating extension's name. It looks like a notification UX overhaul is on the way, #1135.

@roblourens roblourens assigned jrieken and unassigned jrieken Feb 23, 2017
@roblourens roblourens added feature-request Request for new features or functionality ux User experience issues labels Feb 23, 2017
@jrieken jrieken added the api label Feb 24, 2017
@jrieken jrieken self-assigned this Feb 24, 2017
@jrieken
Copy link
Member

jrieken commented Feb 24, 2017

I like, we already to that for status bar messages

@jrieken jrieken added this to the March 2017 milestone Feb 24, 2017
@jrieken
Copy link
Member

jrieken commented Mar 7, 2017

I postpone this until we get the new notification story in place

@ryh
Copy link

ryh commented Apr 14, 2017

Could you tell us which API for extension can send the message.
some FUNCTION called showInformationMessage or just showInformationMessage ?

@jrieken
Copy link
Member

jrieken commented Aug 17, 2017

@bpasero Given that this annoys people is there something the message service can do with ease?

@bpasero
Copy link
Member

bpasero commented Aug 17, 2017

@jrieken so for the status bar you were talking about this right?

image

Our notification UX needs an overhaul (we started to revisit this recently but it needs more thinking - @stevencl fyi) and so we have only limited amount of things we can do in the UI.

A couple of ideas

  • add another button at the end of each message that comes from an extension to "Manage" that extension (a bit ugly because it makes the whole thing even more complicated)
  • prefix the message with the name of the extension (e.g. [TypeScript] bla bla)
  • decorate the message in some way that its clear the message is from an extension (maybe with the prefix as stated before):

image

We should do something pragmatic and simple given that this UI is throwaway code anyways.

@jrieken jrieken added this to the August 2017 milestone Aug 18, 2017
jrieken added a commit that referenced this issue Aug 18, 2017
@jrieken
Copy link
Member

jrieken commented Aug 18, 2017

To begin with, I have added a source attribute that show on hover....

aug-18-2017 16-57-09

@jrieken
Copy link
Member

jrieken commented Aug 21, 2017

Refined this to show the extension id along the extension name and to also show the hover on the severity label

@sandy081 sandy081 added the verified Verification succeeded label Aug 30, 2017
@sandy081
Copy link
Member

sandy081 commented Aug 30, 2017

@jrieken I think it has to be extension display name instead of extension.name. extension id is nothing but ${publisher_id}.${extension.name}. Showing extension name again is redundant.

kapture 2017-08-30 at 10 42 37

Shall I file a separate issue or reopen this?

@jrieken
Copy link
Member

jrieken commented Aug 30, 2017

@sandy081 Please make a separate issue, thanks

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants