Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[04e] potential listener LEAK detected, having 175 listeners already. MOST frequent listener (1): #213141

Closed
vscodenpa opened this issue May 21, 2024 · 2 comments · Fixed by #214456
Assignees
Labels
editor-core Editor basic functionality error-telemetry VS Code - Issues generated by telemetry insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@vscodenpa
Copy link

Error
at c.create in src/vs/base/common/event.ts:900:15
at r.q [as onDidChange] in src/vs/base/common/event.ts:1095:34
at new v in src/vs/editor/common/model/bracketPairsTextModelPart/bracketPairsImpl.ts:41:38
at new x in src/vs/editor/common/model/textModel.ts:327:39
at $.J in src/vs/editor/common/services/modelService.ts:317:28
at $.createModel in src/vs/editor/common/services/modelService.ts:452:21
at <anonymous> in src/vs/workbench/api/browser/mainThreadDocumentContentProviders.ts:49:33
at async h.u in src/vs/workbench/services/textmodelResolver/common/textModelResolverService.ts:187:18
at async h.r in src/vs/workbench/services/textmodelResolver/common/textModelResolverService.ts:78:4
at async k.acquire in src/vs/base/common/lifecycle.ts:683:19
at async l.createModelReference in src/vs/workbench/services/textmodelResolver/common/textModelResolverService.ts:238:10
at async s.y in src/vs/workbench/api/browser/mainThreadDocuments.ts:254:15
at async s.$tryOpenDocument in src/vs/workbench/api/browser/mainThreadDocuments.ts:234:18

Go to Errors Site

@vscodenpa vscodenpa added the error-telemetry VS Code - Issues generated by telemetry label May 21, 2024
@jrieken
Copy link
Member

jrieken commented May 21, 2024

Not yet sure if this is too many models opened by extensions or something with this particular listener

@jrieken
Copy link
Member

jrieken commented May 22, 2024

related to #213209

@hediet This is about ILanguageConfigurationService#onDidChange and about having very many models in memory. I believe a simple, low-hanging improvement is have TextModel listen only once. Today, it listen via BracketPairsTextModelPart and TokenizationTextModelPart

@hediet hediet added this to the May 2024 milestone May 27, 2024
jrieken added a commit that referenced this issue May 29, 2024
jrieken added a commit that referenced this issue May 29, 2024
@jrieken jrieken removed their assignment May 30, 2024
@hediet hediet modified the milestones: May 2024, June 2024 May 30, 2024
@hediet hediet added the editor-core Editor basic functionality label Jun 6, 2024
hediet added a commit that referenced this issue Jun 6, 2024
@hediet hediet mentioned this issue Jun 6, 2024
hediet added a commit that referenced this issue Jun 6, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 6, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-core Editor basic functionality error-telemetry VS Code - Issues generated by telemetry insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants