off topic request throws error

[meganrogge]

Testing #213552

1. Use unmodified chat extension sample
2. Run @cat tell me a story
3. 🐛 see Language model errored (I'd expect to see the off topic filter)
4. In dev tools:

 ERR [CHAT] extension request ERRORED Error: filtered as off_topic by intent classifier: message was not programming related
    at u2.provideLanguageModelResponse (/Applications/code-insiders-portable-data/extensions/github.copilot-chat-0.16.2024052801/dist/extension.js:1001:3622)
    at processTicksAndRejections (node:internal/process/task_queues:95:5) vscode-samples.chat-sample 496141
log.ts:439   ERR filtered as off_topic by intent classifier: message was not programming related: Error: filtered as off_topic by intent classifier: message was not programming related
    at u2.provideLanguageModelResponse (/Applications/code-insiders-portable-data/extensions/github.copilot-chat-0.16.2024052801/dist/extension.js:1001:3622)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Here are the logs, keyword: failed request for the logs that happened around this time
logs.txt

[jrieken]

We have two options (and should do both)

1. update the sample to do proper error handling (@isidorn)
2. do nicer error printing when invoking a participant fails

[isidorn]

I can do 1. I would just log the error. Let me know if there is anything more creative I could do in error handling.

[jrieken]

How about printing a nice message and logging the ugly error to the console/log-file?

[meganrogge]

Should this be labeled a bug so it gets verified @jrieken ?

[jrieken]

Should this be labeled a bug so it gets verified @jrieken ?

Sure, sure but I not yet certain that what I have changed is enough ;-)

[jrieken]

Let's treat this as fixed

[alexr00]

What am I supposed to see? I see this in the console:

and this in the chat view:

[meganrogge]

before, there was just a generic error message. now there's a specific one indicating it was off topic. I believe that's what the fix was

[roblourens]

Yeah, ugly raw error but at least we expose the real error instead of the wrapper, so I think this is good default behavior.