Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook.codeActionsOnSave is difficult to use without autocomplete #213718

Closed
Tyriar opened this issue May 28, 2024 · 0 comments · Fixed by #221510
Closed

notebook.codeActionsOnSave is difficult to use without autocomplete #213718

Tyriar opened this issue May 28, 2024 · 0 comments · Fixed by #221510
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-code-actions Notebook editor code actions notebook-format Formatting support for notebooks under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 28, 2024

Testing #213608

I have the following set:

{
  "notebook.codeActionsOnSave": {
    "notebook.format.extensionName": "never"
  },
  "notebook.formatOnSave.enabled": true,
}

When using the sample extension at https://github.com/microsoft/vscode-extension-samples/tree/main/notebook-format-code-action-sample I expect this to not trigger the code action on save but it does do it. Because there is no auto-complete I tried a bunch of other things also to no avail.

@Yoyokrazy Yoyokrazy added under-discussion Issue is under discussion for relevance, priority, approach notebook-format Formatting support for notebooks notebook-code-actions Notebook editor code actions labels May 29, 2024
@justschen justschen self-assigned this May 31, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jul 15, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the July 2024 milestone Jul 15, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 16, 2024
@justschen justschen added the bug Issue identified by VS Code Team member as probable bug label Jul 22, 2024
@lramos15 lramos15 added the verified Verification succeeded label Jul 25, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-code-actions Notebook editor code actions notebook-format Formatting support for notebooks under-discussion Issue is under discussion for relevance, priority, approach verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants