Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook.codeActionsOnSave doesn't respect "never" #213719

Open
Tyriar opened this issue May 28, 2024 · 0 comments
Open

notebook.codeActionsOnSave doesn't respect "never" #213719

Tyriar opened this issue May 28, 2024 · 0 comments
Assignees
Labels
notebook-code-actions Notebook editor code actions notebook-format Formatting support for notebooks under-discussion Issue is under discussion for relevance, priority, approach

Comments

@Tyriar
Copy link
Member

Tyriar commented May 28, 2024

Testing #213608

Related: #213718

I have the following set:

{
  "notebook.codeActionsOnSave": {
    "notebook.format.extensionName": "never"
  },
  "notebook.formatOnSave.enabled": true,
}

When using the sample extension at https://github.com/microsoft/vscode-extension-samples/tree/main/notebook-format-code-action-sample I expect this to not trigger the code action on save but it does do it.

@Yoyokrazy Yoyokrazy added under-discussion Issue is under discussion for relevance, priority, approach notebook-format Formatting support for notebooks notebook-code-actions Notebook editor code actions labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook-code-actions Notebook editor code actions notebook-format Formatting support for notebooks under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants