Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel visibility is not persisted/restored on vscode.dev after restart #213885

Closed
yiliang114 opened this issue May 30, 2024 · 1 comment
Closed

Panel visibility is not persisted/restored on vscode.dev after restart #213885

yiliang114 opened this issue May 30, 2024 · 1 comment
Assignees
@bpasero
Labels
confirmed Issue has been confirmed by VS Code Team member debt Code quality issues help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues vscode.dev Issues related to vscode.dev workbench-state UI state across restarts
Milestone
June 2024

Comments

@yiliang114
Copy link
Contributor

  1. Open https://vscode.dev/
  2. Open Termial or other Panel like this
  3. image
  4. Use cmd + r to refresh the page, click the confirmation pop-up box, and refresh to find that the panel is open at this time (the status is recorded)
  5. Then close the panel and click the refresh button in the address bar directly. after the refresh, it is found that the panel has not been closed (the status is not recorded).

reload1

Version: 1.89.1
Commit: dc96b83
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36
Embedder: vscode.dev
@yiliang114 yiliang114 mentioned this issue May 30, 2024
Closed
yiliang114 added a commit to yiliang114/vscode that referenced this issue May 30, 2024
@yiliang114
Fix microsoft#213885, make doShutdown asynchronous and wait for stora…
e3e0351 
…ge service flush when triggered by beforeunload
yiliang114 added a commit to yiliang114/vscode that referenced this issue May 30, 2024
@yiliang114
Fix microsoft#213885, make doShutdown asynchronous and wait for stora…
06069bb 
…ge service flush when triggered by beforeunload
yiliang114 added a commit to yiliang114/vscode that referenced this issue May 30, 2024
@yiliang114
Fix microsoft#213885, make doShutdown asynchronous and wait for stora…
7a3345a 
…ge service flush when triggered by beforeunload
@andreamah andreamah assigned joyceerhl and unassigned andreamah May 30, 2024
@joyceerhl joyceerhl assigned bpasero and unassigned joyceerhl May 30, 2024
@bpasero bpasero changed the title Refresh button in the address bar, view cache cannot be updated normally. Panel visibility is not persisted on vscode.dev after restart May 31, 2024
@bpasero bpasero changed the title Panel visibility is not persisted on vscode.dev after restart Panel visibility is not persisted/restored on vscode.dev after restart May 31, 2024
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities confirmed Issue has been confirmed by VS Code Team member vscode.dev Issues related to vscode.dev layout General VS Code workbench layout issues workbench-state UI state across restarts labels May 31, 2024
bpasero added a commit that referenced this issue Jun 1, 2024
@bpasero
Panel visibility is not persisted/restored on vscode.dev after restart (
8012507 
fix #213885)
@bpasero bpasero added this to the June 2024 milestone Jun 1, 2024
@bpasero
Copy link
Member

bpasero commented Jun 1, 2024

As it turns out, the layout was not flushed every 5 seconds to state as we do in other cases:

vscode/src/vs/workbench/browser/layout.ts

Line 1537 in fca05df

if (willSaveState.reason === WillSaveStateReason.SHUTDOWN) {

Changing that to be included in the flush should fix this, at least as long as you do not reload before 5 seconds have passed.

@bpasero bpasero closed this as completed in 60d7343 Jun 1, 2024
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 1, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 5, 2024
@bpasero bpasero added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Jun 19, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
confirmed Issue has been confirmed by VS Code Team member debt Code quality issues help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues vscode.dev Issues related to vscode.dev workbench-state UI state across restarts
Projects
None yet
Milestone
June 2024
Development

Successfully merging a pull request may close this issue.

Fix #213885, As much as possible flush the storage in beforeunload callback yiliang114/vscode
5 participants
@bpasero @yiliang114 @joyceerhl @andreamah @vscodenpa