Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer create branch when running Git: Checkout #21439

Closed
ttftw opened this issue Feb 26, 2017 · 20 comments
Closed

Can no longer create branch when running Git: Checkout #21439

ttftw opened this issue Feb 26, 2017 · 20 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Milestone

Comments

@ttftw
Copy link

ttftw commented Feb 26, 2017

  • VSCode Version: Code - Insiders 1.10.0-insider (b2a55bd, 2017-02-24T20:35:46.683Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
vscode-eslint dbaeumer 1.2.6
vscode-icons robertohuertasm 7.3.0

Steps to Reproduce:

  1. Click branch in bottom right
  2. New window no longer allows to create branch

Here is what it looked like before the insider release:
image

Now the option is purely branch to checkout:
image

@joaomoreno
Copy link
Member

joaomoreno commented Feb 28, 2017

@bpasero Could we augment the current pick API such that I still get what the user typed? Possibly I should also be able to update the informational message, as the user types.

@joaomoreno joaomoreno added this to the Backlog milestone Feb 28, 2017
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues labels Feb 28, 2017
@bpasero
Copy link
Member

bpasero commented Feb 28, 2017

@joaomoreno you mean to have API to return what the user typed even if there is no matching pick entry in the list?

@joaomoreno
Copy link
Member

Yeah, corrected my typo, sorry!

@bpasero
Copy link
Member

bpasero commented Feb 28, 2017

Makes sense, I think we can add something to the QuickPickOptions API.

/cc @jrieken on the idea of #21439 (comment)

@jrieken
Copy link
Member

jrieken commented Feb 28, 2017

@joaomoreno You want a combination of quick pick and input box, right? Since the API promises to return one of the items (can be objects) it is tricky to just come up with an item based on invalid user input. This needs thinking...

@ttftw
Copy link
Author

ttftw commented Mar 1, 2017

This seems to be resolved on the build released today.

image

@bpasero
Copy link
Member

bpasero commented Mar 2, 2017

@Meowbeast we only enabled the new SCM features in the insiders release. Since you seem to be using stable, you are back to the old SCM world.

@Haroenv
Copy link

Haroenv commented Mar 25, 2017

So how do you make a new branch now, isn’t it possible anymore?

@joaomoreno
Copy link
Member

There's a global command Git: Create Branch...

image

@stefannikolei
Copy link

Anything on this. This one made it into the new stable release. Missing the workflow of just clicking the branch in the lower left and create a new one from it

@akulbe
Copy link

akulbe commented Apr 8, 2017

It's interesting that this was marked a duplicate. I was able to create a git branch successfully from 1.10.2 (that was the third screenshot I included in my report #24315). ¯\_(ツ)_/¯

Thank you for your work, in any case!!

@ryanbowden
Copy link

Any idea when this one will be fixed?

@joaomoreno joaomoreno changed the title Can no longer create branch Can no longer create branch when running Git: Checkout Apr 10, 2017
@joaomoreno
Copy link
Member

It is assigned for April 2017 right there in the Milestone assignment.

@eamodio
Copy link
Contributor

eamodio commented Apr 10, 2017

Even outside of this issue, I think it would be great if this ability was added (opt-in) of course to the QuickPickOptions as suggested here #21439 (comment)

@AmirSavand
Copy link

I really liked it when you just click on the branch name on bottom left and start typing the branch you want to create. no longer there 😢

@joaomoreno
Copy link
Member

Gonna have to push this until we figure out a good API for it: #25140

@joaomoreno joaomoreno modified the milestones: Backlog, April 2017 Apr 21, 2017
@jeffmcaffer
Copy link

Using 1.11.2 and have to say I really miss the click and type experience. It is unclear from the comments above if it will be coming back.

@akulbe
Copy link

akulbe commented May 3, 2017

Is it possible to bring the functionality back on a temporary basis, while the larger API issues get sorted out? Please? @jrieken @joaomoreno

@kai23
Copy link

kai23 commented Jun 20, 2017

Is there any update of this removed-but-everyone-like-it feature ? :)

@joaomoreno joaomoreno modified the milestones: July 2017, Backlog Jul 5, 2017
@joaomoreno
Copy link
Member

Found a little workaround for this. 👍

image

joaomoreno added a commit that referenced this issue Jul 5, 2017
@roblourens roblourens added the verified Verification succeeded label Aug 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests