Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestMessage display incorrectly when it's a markdown string in 1.92.0 #224575

Closed
jdneo opened this issue Aug 2, 2024 · 3 comments
Closed

TestMessage display incorrectly when it's a markdown string in 1.92.0 #224575

jdneo opened this issue Aug 2, 2024 · 3 comments
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release testing Built-in testing support verified Verification succeeded
Milestone
July 2024 Recovery 1

Comments

@jdneo
Copy link
Member

jdneo commented Aug 2, 2024

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.92.0 (Universal)
Commit: b1c0a14
Date: 2024-07-31T23:26:45.634Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.5.0

Steps to Reproduce:

  1. Using this snippet in the test-provider-sample project
const markdownString = new vscode.MarkdownString();
markdownString.isTrusted = true;
markdownString.supportHtml = true;
markdownString.appendText("foo");
markdownString.appendMarkdown("<br/>");
markdownString.appendText("bar");
const message = new vscode.TestMessage(markdownString);
message.location = new vscode.Location(item.uri!, item.range!);
options.failed(item, message, duration);
  1. After running the test, both the editor peek view and test result view do not render correctly.

image
@jdneo jdneo mentioned this issue Aug 2, 2024
Closed
connor4312 added a commit that referenced this issue Aug 2, 2024
@connor4312
testing: fix markdown messages not displaying
5b385c8 
At the time markdown messages were rendered, the output element was not
in the DOM, so its height was always 0. It was also missing a couple of
style adjustments. Additionally it tweaks the diff height before we
fall back to nested scrollbars -- a limit of 1000px was very low.

I had this commit on a branch from earlier but it never made it to PR :x

Refs #224575
@connor4312 connor4312 mentioned this issue Aug 2, 2024
Merged
@connor4312 connor4312 added this to the July 2024 Recovery 1 milestone Aug 2, 2024
@connor4312 connor4312 added the candidate Issue identified as probable candidate for fixing in the next release label Aug 2, 2024
@connor4312
Copy link
Member

Sorry, this got lost in the shuffle of the call stack UI :(

connor4312 added a commit that referenced this issue Aug 2, 2024
@connor4312
testing: fix markdown messages not displaying
55013f9 
At the time markdown messages were rendered, the output element was not
in the DOM, so its height was always 0. It was also missing a couple of
style adjustments. Additionally it tweaks the diff height before we
fall back to nested scrollbars -- a limit of 1000px was very low.

I had this commit on a branch from earlier but it never made it to PR :x

Refs #224575
@connor4312 connor4312 mentioned this issue Aug 2, 2024
Merged
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Aug 2, 2024
connor4312 added a commit that referenced this issue Aug 2, 2024
@connor4312
testing: fix markdown messages not displaying (#224611)
763c20f 
At the time markdown messages were rendered, the output element was not
in the DOM, so its height was always 0. It was also missing a couple of
style adjustments. Additionally it tweaks the diff height before we
fall back to nested scrollbars -- a limit of 1000px was very low.

I had this commit on a branch from earlier but it never made it to PR :x

Refs #224575
connor4312 added a commit that referenced this issue Aug 5, 2024
@connor4312
testing: fix markdown messages not displaying (#224612)
477cb27 
At the time markdown messages were rendered, the output element was not
in the DOM, so its height was always 0. It was also missing a couple of
style adjustments. Additionally it tweaks the diff height before we
fall back to nested scrollbars -- a limit of 1000px was very low.

I had this commit on a branch from earlier but it never made it to PR :x

Refs #224575
@connor4312
Copy link
Member

connor4312 commented Aug 7, 2024 •
edited
Loading

Verification steps:

  1. Check out the connor4312/verify-224575 of vscode-extension-samples https://github.com/microsoft/vscode-extension-samples
  2. Go into test-provider-sample and F5
  3. Run the "easy math" test in test.md. Open the error messages for all the tests that fail and verify they're all visible

@rebornix rebornix added the verified Verification succeeded label Aug 7, 2024
zongou pushed a commit to zongou/vscode that referenced this issue Aug 13, 2024
@connor4312 @zongou
testing: fix markdown messages not displaying (microsoft#224612)
1115de5 
At the time markdown messages were rendered, the output element was not
in the DOM, so its height was always 0. It was also missing a couple of
style adjustments. Additionally it tweaks the diff height before we
fall back to nested scrollbars -- a limit of 1000px was very low.

I had this commit on a branch from earlier but it never made it to PR :x

Refs microsoft#224575
@Mati882023
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.92.0 (Universal) Commit: b1c0a14 Date: 2024-07-31T23:26:45.634Z Electron: 30.1.2 ElectronBuildId: 9870757 Chromium: 124.0.6367.243 Node.js: 20.14.0 V8: 12.4.254.20-electron.0 OS: Darwin arm64 23.5.0

Steps to Reproduce:

  1. Using this snippet in the test-provider-sample project
const markdownString = new vscode.MarkdownString();
markdownString.isTrusted = true;
markdownString.supportHtml = true;
markdownString.appendText("foo");
markdownString.appendMarkdown("<br/>");
markdownString.appendText("bar");
const message = new vscode.TestMessage(markdownString);
message.location = new vscode.Location(item.uri!, item.range!);
options.failed(item, message, duration);
  1. After running the test, both the editor peek view and test result view do not render correctly.

image

mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Sep 2, 2024
@connor4312 @mustard-mh
testing: fix markdown messages not displaying (microsoft#224612)
18e945a 
At the time markdown messages were rendered, the output element was not
in the DOM, so its height was always 0. It was also missing a couple of
style adjustments. Additionally it tweaks the diff height before we
fall back to nested scrollbars -- a limit of 1000px was very low.

I had this commit on a branch from earlier but it never made it to PR :x

Refs microsoft#224575
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release testing Built-in testing support verified Verification succeeded
Projects
None yet
Milestone
July 2024 Recovery 1
Development

No branches or pull requests
4 participants
@rebornix @connor4312 @jdneo @Mati882023