Embedded languages syntax highlighting stopped working in 1.92.0

[staspiter]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.92.0
• OS Version: Windows 10, macOS 14 Sonoma

I have been using the following two extensions a lot. Since 1.92.0 update both extensions stopped working meaning the embedded code in JS does not get highlighted inside of YAML anymore. Each extension basically does the same job for me, so I tried to switch from one to another before realizing that my VSCode got an update and this functionality stopped working in both extensions. I've also tried the insiders build and the problem is still there. When I downgraded to 1.91.1, the extensions worked perfectly. This happens on both Windows and Mac.

The extensions are:

1. Extended Embedded Languages - https://marketplace.visualstudio.com/items?itemName=ruschaaf.extended-embedded-languages
2. YAML Embedded Languages - https://marketplace.visualstudio.com/items?itemName=harrydowning.yaml-embedded-languages

Steps to reproduce:

1. Install VSCode 1.92.0 or the insiders build.
2. Install one of the above extensions.
3. Create a yaml file with the following content:

test: | #js
  console.log("hello world")

4. Make sure the js code gets highlighted correctly

This is how it looks like in 1.92.0

1.91.1:

[mjbvz]

Possibly fixed by #224954

[staspiter]

Installing this extension https://marketplace.visualstudio.com/items?itemName=redhat.vscode-yaml helps as a workaround. I guess because it takes over the yaml grammar and completes it with what is expected by other extensions.

[alexr00]

Duplicate of #224862.

Should be fixed by #224954 in the very latest insiders (from d4c4e69) and will be fixed in the upcoming recovery release.

[RedCMD]

"block-scalar" was taking precedence over injections because it was consuming the whitespace before it while the embedded language extensions were not

if I remove the ([\t ]*+) part
it starts working

but it will still break down when inside a nested block-map

this is because the other extensions use ^ instead of (^|\\G)
they will need to fix that part for themselves
Extended Embedded Languages
YAML Embedded Languages

[RedCMD]

@alexr00 VSCode needs to pull the latest yaml commits to fix this
RedCMD/YAML-Syntax-Highlighter@71a8871

sorry, I was under the impression the changes had already gone through
but it seems I missed the pull update by a few hours? #224954

[alexr00]

Re-using the old candidate here as this is a separate issue: #224862

[RedCMD]

separate issue?
#224862 is already fixed tho?

@harrydowning has already pushed a temporary patch to his extension in the meantime harrydowning/vscode-yaml-embedded-languages#45

[alexr00]

I'm seeing #224862 still occur. I guess I can't say for certain whether it's a separate issue since #224862 is still happening.

[ruschaaf]

I'm the author of the Extended Embedded Language plugin mentioned above. Thank you @RedCMD for the suggestions and patches you've given. I'm seeing a problem now on VSCode 1.93.0 using YAML as an embedded language - e.g. putting yaml inside Python or C++. The issue seems to be the similar to #20488 which I've come across in some other embedded grammars where the embedded grammar captures the end-of-string token before the host can see it, so the embedded language highlighting "leaks" out of its string. In the past I've had to remove potential embedded languages because of this, but YAML is too useful to just remove so I wanted to see if there was a workaround?

[RedCMD]

Fixed in the latest version of my grammar

all reported issues are fixed now

• VSCode 1.92 YAML grammar breaks MDX syntax highlighting #224862
• YAML Syntax Highlighting vuejs/language-tools#4654
• Code lines are struckthrough and red #220022

[alexr00]

Awesome, I'll try adopting https://github.com/RedCMD/YAML-Syntax-Highlighter again for the November milestone.

[alexr00]

@RedCMD I'm still seeing the original bug:

[RedCMD]

@alexr00 that is highlighted correctly

from RedHat:

[RedCMD]

if you think it is an issue
then a new report should be made

as #224862 has been fixed by me and by the mdx extension

[alexr00]

Thanks @RedCMD, I forgot to install the MDX extension 🤦‍♀️

I've gone through the issues, and they all no longer repro with your changes 🚀

[alexr00]

For using yaml as an embedded language in C++ with Extend Embedded Languages, I see the following:

The yaml scope doesn't escape outside of the string, but it also doesn't get any yaml scopes besides source.yaml.

[vs-code-engineering]

This bug has been fixed in the latest release of VS Code Insiders!

@staspiter, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version a1fc8c1 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!