Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location references for variable values don't work in SSH-remote sessions #225967

Closed
vogelsgesang opened this issue Aug 19, 2024 · 4 comments · Fixed by #226193
Closed

Location references for variable values don't work in SSH-remote sessions #225967

vogelsgesang opened this issue Aug 19, 2024 · 4 comments · Fixed by #226193
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@vogelsgesang
Copy link

vogelsgesang commented Aug 19, 2024

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: Version: 1.93.0-insider (Universal), Commit: 27f650e
  • OS Version: macOS Sonoma 14.6.1

The recently introduced support for location references for variable values (#225546) seems to be only working for local debugging sessions. For remote debugging sessions using the Remote SSH extension, the links from the debug adapter are not resolved correctly.

This was previously reported in #225546 (comment). By now, I confirmed that this works as expected in a local, non-remote debugging session. Hence, my suspicion that this is a bug in VS-Code / the SSH extension.

Observed Behavior: Remote Debugging through SSH

In the screen recording, we can see:

  • The function pointers are shown in the variables view and the corresponding values are linked, as indicated by the underline when hovering the value
  • When Cmd+Clicking on the value, the link is followed
  • The link leads to an error message.
value-location.mov

Towards the bottom of the screen, you can see the messages sent to/from lldb-dap. Note how it refers to the file as /home/avogelsgesang/Documents/corotest/test-ptr.cpp. This is the exact same path which is also used by the debug adapter in responses to stackTrace commands, and for stack traces this path is correctly linked.

In a couple of other requests, I am seeing VS-Code to refer to this path as vscode-remote://ssh-remote%2Bavogelsges-wsl2/home/avogelsgesang/Documents/corotest/test-ptr.cpp. I suspect that some path mapping for remote files is still missing here?

Observed Behavior: Local debugging

Debugging locally, in a non-remote session, works as expected:

value-location2.mov

Steps to Reproduce

  1. Install a VS-Code Insiders version
  2. Setup a SSH remote editing session
  3. Setup lldb-dap
  4. Debug a program which contains function pointers. Pause the program such that the function pointers are in the "Variables View"
  5. Cmd+Click on any of the function pointer values
@vogelsgesang
Copy link
Author

FYI @connor4312

@connor4312 connor4312 assigned connor4312 and unassigned roblourens Aug 21, 2024
@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Aug 21, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 24, 2024
@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 24, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2024
@rzhao271 rzhao271 added the author-verification-requested Issues potentially verifiable by issue author label Aug 28, 2024
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@vogelsgesang, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version d1388fd of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@connor4312
Copy link
Member

Verification steps:

  1. Connect to a remote machine
  2. Use js-debug to debug something
  3. Pause with a function in your Variables view, and verify you can ctrl+click to go to its definition location

@rzhao271
Copy link
Contributor

Verified with Remote WSL if that counts

@rzhao271 rzhao271 added the verified Verification succeeded label Aug 29, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants