Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to read from stdin #229962

Closed
iosmanthus opened this issue Sep 27, 2024 · 3 comments
Closed

Fail to read from stdin #229962

iosmanthus opened this issue Sep 27, 2024 · 3 comments
Assignees
@bpasero
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority regression Something that used to work is now broken verified Verification succeeded workbench-cli VS Code Command line issues
Milestone
September 2024

Comments

@iosmanthus
Copy link

iosmanthus commented Sep 27, 2024 •
edited
Loading

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 
     1.94.0-insider
 c43f508b732d24b0c4732de9db2b38b4c5b88b8a
 x64
  • OS Version: NixOS 24.05 and Windows 11 22000.2538

Steps to Reproduce:

  1. echo "Hello World" | code-insiders -
  2. It reports the following error and fails to read from stdin.
Failed to create file to read via stdin: TypeError: i.encodingExists is not a function

I have located the root cause: https://github.com/microsoft/vscode/blob/6043ad16d1279f823ff24dfa289cba6e3d0e937a/src/vs/platform/environment/node/stdin.ts#L45C3-L45C35
@iosmanthus iosmanthus mentioned this issue Sep 27, 2024
Closed
@bpasero bpasero self-assigned this Sep 27, 2024
@bpasero bpasero added important Issue identified as high-priority candidate Issue identified as probable candidate for fixing in the next release workbench-cli VS Code Command line issues regression Something that used to work is now broken labels Sep 27, 2024
@bpasero bpasero modified the milestones: October 2024, September 2024 Sep 27, 2024
@bpasero
Copy link
Member

bpasero commented Sep 27, 2024

Great catch!

bpasero added a commit that referenced this issue Sep 27, 2024
@bpasero
Fail to read from stdin (#229962)
3546417
bpasero added a commit that referenced this issue Sep 27, 2024
@bpasero
Fail to read from stdin (#229962)
c4bcc76
bpasero added a commit that referenced this issue Sep 27, 2024
@bpasero
Fail to read from stdin (#229962) (#229967)
a1afeb6
bpasero added a commit that referenced this issue Sep 30, 2024
@bpasero
Fail to read from stdin (fix #229962) (#229968)
b7894e6 
Fail to read from stdin (#229962)
@bpasero bpasero closed this as completed Sep 30, 2024
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 30, 2024
@bpasero
Copy link
Member

bpasero commented Sep 30, 2024

The fix should be in, could you verify after having pulled in the latest insiders update?

@rzhao271 rzhao271 added the author-verification-requested Issues potentially verifiable by issue author label Sep 30, 2024
@iosmanthus
Copy link
Author

iosmanthus commented Oct 1, 2024 •
edited
Loading

The fix should be in, could you verify after having pulled in the latest insiders update?

Yes, it works on the latest insiders with commit b7894e64dd103a19dd5015326d8310232236de0f. Thank you ❤️.

@bpasero bpasero added the verified Verification succeeded label Oct 1, 2024
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Oct 9, 2024
@bpasero @mustard-mh
Fail to read from stdin (fix microsoft#229962) (microsoft#229968)
c86574d 
Fail to read from stdin (microsoft#229962)
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority regression Something that used to work is now broken verified Verification succeeded workbench-cli VS Code Command line issues
Projects
None yet
Milestone
September 2024
Development

Successfully merging a pull request may close this issue.

fix @vscode/iconv-lite-umd import in stdin iosmanthus/vscode
3 participants
@bpasero @rzhao271 @iosmanthus