Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spawning terminals on windows should not be throttled when using conpty.dll #229982

Closed
Tyriar opened this issue Sep 27, 2024 · 0 comments · Fixed by #229984
Closed

Spawning terminals on windows should not be throttled when using conpty.dll #229982

Tyriar opened this issue Sep 27, 2024 · 0 comments · Fixed by #229984
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders perf terminal-conpty Integrated terminal issues related to the ConPTY backend terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Milestone
October 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2024

Set "terminal.integrated.experimental.windowsUseConptyDll": true and create a bunch of terminals quickly. There should not be a 250ms interval between the processes being spawned created, they should all be spawned quickly.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug perf terminal-conpty Integrated terminal issues related to the ConPTY backend terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. labels Sep 27, 2024
@Tyriar Tyriar added this to the October 2024 milestone Sep 27, 2024
@Tyriar Tyriar self-assigned this Sep 27, 2024
Tyriar added a commit that referenced this issue Sep 27, 2024
@Tyriar
Remove spawn throttle when using conpty.dll
ce6eaa7 
Fixes #229982
Tyriar added a commit that referenced this issue Sep 27, 2024
@Tyriar
Remove spawn throttle when using conpty.dll
56eabd9 
Fixes #229982
@Tyriar Tyriar mentioned this issue Sep 27, 2024
Merged
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 27, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 24, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders perf terminal-conpty Integrated terminal issues related to the ConPTY backend terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Projects
None yet
Milestone
October 2024
Development

Successfully merging a pull request may close this issue.

Remove spawn throttle when using conpty.dll microsoft/vscode
2 participants
@Tyriar @rzhao271