Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+I Copilot prompt showing in nb diff, but shortcut is a noop #229995

Closed
Yoyokrazy opened this issue Sep 27, 2024 · 2 comments
Closed

Ctrl+I Copilot prompt showing in nb diff, but shortcut is a noop #229995

Yoyokrazy opened this issue Sep 27, 2024 · 2 comments
Assignees
@DonJayamanne
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug notebook-diff verified Verification succeeded
Milestone
January 2025

Comments

@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Sep 27, 2024 •
edited
Loading

Type: Bug

Two empty cells in a notebook, save, the notebook metadata changes to add nbformat fields.

In notebook diff viewer, the Press ctrl+I to ask Github Copilot... prompt shows int he input fields for the two cells. The input fields are editable but ctrl + I is just a noop.

Further, the copilot prompt does not disappear, leading to visual bugs and screen cheese.

image

VS Code version: Code - Insiders 1.94.0-insider (d445ba0, 2024-09-26T20:48:39.182Z)
OS version: Windows_NT x64 10.0.26100
Modes:

System Info
Item Value
CPUs 12th Gen Intel(R) Core(TM) i7-1265U (12 x 2688)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Load (avg) undefined
Memory (System) 31.83GB (13.51GB free)
Process Argv --crash-reporter-id a1a3a7b6-5c3c-46e6-8403-0fcf483f7d3c
Screen Reader no
VM 0%
Extensions (16)
Extension Author (truncated) Version
better-comments aar 3.0.2
vscode-eslint dba 3.0.13
gitlens eam 2024.9.2705
EditorConfig Edi 0.16.4
prettier-vscode esb 11.0.0
copilot Git 1.234.1127
copilot-chat Git 0.21.2024092702
vscode-pull-request-github Git 0.97.2024092604
extension-test-runner ms- 0.0.12
js-debug-nightly ms- 2024.9.2517
test-adapter-converter ms- 0.1.9
vscode-diagnostic-tools ms- 1.2.0
vscode-github-issue-notebooks ms- 0.0.130
vscode-smoketest-check ms- 0.0.1
vscode-typescript-next ms- 5.7.20240926
vscodeintellicode-completions Vis 2.0.0

(3 theme extensions excluded)

A/B Experiments 
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
vsaa593:30376534
py29gd2263:31024238
c4g48928:30535728
a9j8j154:30646983
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonnoceb:30776497
asynctok:30898717
dsvsc014:30777825
dsvsc015:30821418
pythonmypyd1:30859725
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
cppperfnew:30980852
pythonait:30973460
bdiig495:31013172
a69g1124:31018687
dvdeprecation:31040973
dwnewjupyter:31046869
nb_pri_only:31057983
nativerepl1:31134653
refactort:31084545
pythonrstrctxt:31093868
flighttreat:31119334
wkspc-onlycs-t:31132770
nativeloc1:31118317
wkspc-ranged-c:31125598
cf971741:31144450
e80f6927:31120813
autoexpandse:31146404
ei213698:31121563
12bdf347:31141542
iacca1:31144502
notype1:31143044
b50ed353:31138333
showbadge:31139796
f8igb616:31140137
@rebornix rebornix self-assigned this Sep 27, 2024
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Sep 27, 2024
@rebornix rebornix added this to the September 2024 milestone Sep 27, 2024
@rebornix rebornix removed the candidate Issue identified as probable candidate for fixing in the next release label Sep 27, 2024
@rebornix rebornix modified the milestones: September 2024, October 2024 Sep 27, 2024
rebornix added a commit that referenced this issue Sep 27, 2024
@rebornix
Fix ##229995. Exclude empty editor hint in notebook diff editor
68a10df
@rebornix
Copy link
Member

Removed from candidate list as it is not a regression.

rebornix added a commit that referenced this issue Sep 27, 2024
@rebornix
Fix ##229995. Exclude empty editor hint in notebook diff editor (#230001
8f86741 
)
@rebornix rebornix modified the milestones: November 2024, On Deck Dec 3, 2024
@rebornix rebornix removed their assignment Dec 9, 2024
@DonJayamanne
Copy link
Contributor

No longer and issue

@DonJayamanne DonJayamanne added the author-verification-requested Issues potentially verifiable by issue author label Dec 10, 2024
@DonJayamanne DonJayamanne modified the milestones: On Deck, January 2025 Dec 10, 2024
@Yoyokrazy Yoyokrazy added the verified Verification succeeded label Jan 29, 2025
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug notebook-diff verified Verification succeeded
Projects
None yet
Milestone
January 2025
Development

No branches or pull requests
3 participants
@rebornix @DonJayamanne @Yoyokrazy