-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sometimes links don't work the first time you click #230010
Labels
bug
Issue identified by VS Code Team member as probable bug
terminal-links
unreleased
Patch has not yet been released in VS Code Insiders
upstream
Issue identified as 'upstream' component related (exists outside of VS Code)
upstream-issue-fixed
The underlying upstream issue has been fixed
upstream-issue-linked
This is an upstream issue that has been reported upstream
Milestone
Comments
Tyriar
added
bug
Issue identified by VS Code Team member as probable bug
terminal-links
labels
Sep 27, 2024
activate is never reached in this case: vscode/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLink.ts Lines 52 to 54 in e0ca49c
|
Tyriar
added a commit
to Tyriar/xterm.js
that referenced
this issue
Sep 27, 2024
This was a very long standing bug that was hard to nail down a repro case. Turns out this was because at some point the current link can get cleared and re-evaluated, I think because of a different fix we made. That caused the object check to fail. So the fix there is to check link equality, not js object equality. Additionally I found we don't dispose of old linkifiers when open is called multiple times. See microsoft/vscode#230010
Upstream fix: xtermjs/xterm.js#5171 |
Tyriar
added
upstream
Issue identified as 'upstream' component related (exists outside of VS Code)
upstream-issue-linked
This is an upstream issue that has been reported upstream
upstream-issue-fixed
The underlying upstream issue has been fixed
labels
Sep 27, 2024
Tyriar
added a commit
that referenced
this issue
Sep 28, 2024
Merged
Tyriar
added a commit
that referenced
this issue
Sep 28, 2024
Tyriar
added a commit
that referenced
this issue
Sep 28, 2024
Tyriar
added a commit
that referenced
this issue
Sep 28, 2024
vs-code-engineering
bot
added
the
unreleased
Patch has not yet been released in VS Code Insiders
label
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Issue identified by VS Code Team member as probable bug
terminal-links
unreleased
Patch has not yet been released in VS Code Insiders
upstream
Issue identified as 'upstream' component related (exists outside of VS Code)
upstream-issue-fixed
The underlying upstream issue has been fixed
upstream-issue-linked
This is an upstream issue that has been reported upstream
Repro seems somewhat reliable:
The text was updated successfully, but these errors were encountered: