Consider to flag keybinding conflicts

[weinand]

testing #23287:

When assigning the same keybinding to different commands, this might result in conflicts (and I have no idea which command gets executed).

I suggest to show a warning next to the keybinding when conflicts exist.

macOS does this too:

[sandy081]

Our story of conflicts is different. Every keybinding has a when context that defines when to invoke the command it is assigned to. Rules to dispatch keybindings are available here. In short

• Keybindings are read from bottom to top
• First entry that matches both the key and when is accepted

This process can only be done during run-time and also there is no proper containment of when contexts.

So my suggestion to show conflicts in new keyboard shortcuts editor is as follows

• Ability to show a list of conflicting keybindings for a given entry.
• Ability to list them in the order of precedence

Above will help in trouble shooting keybinding conflicts.

[sandy081]

[cleidigh]

@weinand
@sandy081
have to sync up with this...
while I got behind with master syncs - @sandy081 you just added more two key bindings
I have a prototype it sorts by precedence, highlights duplicates alongside the overridden binding
I also have a sort by when using only contiguous characters and that column
see duplicates screenshot below

can I get looped in to help with these issues?

[sandy081]

@cleidigh Can you please use the issue #22748 for discussion and move the above conversation to there? This issue is closed and the above discussion is mainly related to #22748.

Thanks

[cleidigh]

@sandy081
do you want to separate the duplicates discussion (I thought this issue with your comments)
from the column sorting ?

[coreylendo]

blockquote, div.yahoo_quoted { margin-left: 0 !important; border-left:1px #715FFA solid !important; padding-left:1ex !important; background-color:white !important; } Yes  Sent from Yahoo Mail for iPhone On Wednesday, April 5, 2017, 13:49, Christopher Leidigh <notifications@github.com> wrote: @sandy081 do you want to separate the duplicates discussion (I thought this issue with your comments) from the column sorting ? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[cleidigh]

@sandy081
deleting and moving now...

just tested your new precedence addition - great
not sure I missed something but what do you think about the duplicate filter I showed above?
I think that's something additional then you have presently, no?
I create the filter without having to search for a key binding and show both entries
should I create a new issue for this potential edition if interested?

[sandy081]

@cleidigh Thanks for testing it and providing the feedback. We can use the issue #22748 for our discussion and feedback.