Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save conflict actions show up for any diff editor, not just one #23420

Closed
isidorn opened this issue Mar 28, 2017 · 2 comments
Closed

Save conflict actions show up for any diff editor, not just one #23420

isidorn opened this issue Mar 28, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 28, 2017

  1. Make a save conflict on a local file on disk
  2. Notice the nice actions in the editor title bar for helping you resolve the conflict
  3. Resolve the conflict in some way. Notice that the actions in the title bar are still there and they are not going away
  4. Reloading vscode finally removes them
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Mar 28, 2017
@bpasero bpasero added this to the March 2017 milestone Mar 28, 2017
@bpasero bpasero changed the title Resolve conflicts on disk title bar commands do not die Resolve save conflicts actions show up for any diff editor as soon as they showed up once Mar 29, 2017
@bpasero
Copy link
Member

bpasero commented Mar 29, 2017

Looks like this was already happening in stable.

@bpasero bpasero modified the milestones: Backlog, March 2017 Mar 29, 2017
@bpasero bpasero changed the title Resolve save conflicts actions show up for any diff editor as soon as they showed up once Get rid of EditorInputActionContributor Mar 29, 2017
@bpasero bpasero added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Mar 29, 2017
@bpasero bpasero modified the milestones: March 2017, Backlog, April 2017 Mar 29, 2017
@bpasero
Copy link
Member

bpasero commented Apr 3, 2017

I fixed the issue with actions showing up in all diff editors and merge this into #22275

To verify:

  • get into a save conflict (make file dirty, make changes from other editor, try to save)
  • click on "Resolve" to start seeing the diff editor with actions to resolve the save conflict
  • verify the actions show up only for the diff editor of the save conflict but a) not for any other editor and b) not for other diff editors
  • verify you can resolve the save conflict by either accepting or reverting (try both)

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed debt Code quality issues labels Apr 3, 2017
@bpasero bpasero closed this as completed Apr 3, 2017
@bpasero bpasero changed the title Get rid of EditorInputActionContributor Save conflict actions show up for any diff editor, not just one Apr 3, 2017
@michelkaporin michelkaporin added the verified Verification succeeded label Apr 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants