Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workbench.list.defaultFindMode seems ignored for Folders View #236770

Closed
starball5 opened this issue Dec 21, 2024 · 2 comments · Fixed by #237057
Closed

workbench.list.defaultFindMode seems ignored for Folders View #236770

starball5 opened this issue Dec 21, 2024 · 2 comments · Fixed by #237057
Assignees
@benibenj
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken tree-widget Tree widget issues
Milestone
January 2025

Comments

@starball5
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.96.2
  • OS Version: Ubuntu 24.10

Steps to Reproduce:

  1. Open VS Code
  2. Put "workbench.list.defaultFindMode": "filter", in user settings.json
  3. Open a workspace folder
  4. Focus the Folders View
  5. Hit whatever keyboard shortcut performs list.find for you
  6. Observe that the find widget is in highlight mode (this is unexpected)
  7. Focus a different view like Open Editors, Outline, or SCM
  8. Hit whatever keyboard shortcut performs list.find for you
  9. Observe that the find widget is in filter mode (as requested by the setting added in step 2)

Related on Stack Overflow: How to set default "find in explorer" mode in VS Code?
@vrad-exe
Copy link

This also appears to apply to workbench.list.defaultFindMatchType

@joaomoreno joaomoreno assigned benibenj and unassigned ulugbekna Dec 23, 2024
benibenj added a commit that referenced this issue Dec 28, 2024
@benibenj
fix #236770
6538656
@benibenj benibenj mentioned this issue Dec 28, 2024
Merged
@benibenj benibenj added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues tree-widget Tree widget issues regression Something that used to work is now broken labels Dec 28, 2024
@benibenj benibenj added this to the January 2025 milestone Dec 28, 2024
@benibenj
Copy link
Contributor

Thanks for reporting this, I've added a fix

@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Dec 29, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benibenj benibenj

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken tree-widget Tree widget issues
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

Fix default tree find modes microsoft/vscode
5 participants
@joaomoreno @ulugbekna @vrad-exe @benibenj @starball5