Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This update switch statement has bug #25971

Closed
MangGoDio opened this issue May 5, 2017 · 5 comments
Closed

This update switch statement has bug #25971

MangGoDio opened this issue May 5, 2017 · 5 comments
Assignees
Labels
*as-designed Described behavior is as designed info-needed Issue requires more information from poster javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@MangGoDio
Copy link

  • VSCode Version: Code 1.12.1 (f6868fc, 2017-05-04T21:26:50.689Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions:
Extension Author Version
html-snippets abusaidm 0.1.0
vscode-theme-onedark akamud 1.3.2
npm-intellisense christian-kohler 1.3.0
path-intellisense christian-kohler 1.2.0
vscode-babel-coloring dzannotti 0.0.4
vscode-html-css ecmel 0.1.2
auto-rename-tag formulahendry 0.0.11
JSDocTagComplete HookyQR 0.0.2
code-beautifier michelemelluso 1.7.2
js-atom-grammar ms-vscode 0.1.12
vscode-icons robertohuertasm 7.6.0
sass-indented robinbentley 1.4.1
ReactSnippets xabikos 1.2.1

Steps to Reproduce:

1.In javascript switch statements break will be prompted to unreachable code detected

@mjbvz mjbvz self-assigned this May 5, 2017
@mjbvz mjbvz added javascript JavaScript support issues info-needed Issue requires more information from poster labels May 5, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 5, 2017

Can you please share a code example

@MangGoDio
Copy link
Author

I'm very sorry, it's my own problem,but It doesn't make sense to “break” after “return”, I'think "warning" a little bit better than "error".
code_2017-05-05_13-49-37

@brendamendez34
Copy link

brendamendez34 commented May 5, 2017 via email

@brendamendez34
Copy link

brendamendez34 commented May 5, 2017 via email

@mjbvz mjbvz added *as-designed Described behavior is as designed upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels May 5, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 5, 2017

Yes, a more general approach would be better than downgrading this error specifically. TypeScript is tracking user configuration error levels here: microsoft/TypeScript#13408

Closing as as-designed / upstream

@mjbvz mjbvz closed this as completed May 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed info-needed Issue requires more information from poster javascript JavaScript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants