Emmet abbreviation with (...)*n doesn't work

[roblourens]

#27316

• div*2 produces 2 divs
• (div)*2 and (div>span)*2 expand -> the abbreviation is replaced with empty string

Works with old emmet

[ramya-rao-a]

@sergeche abbreviations like (...)*n are getting expanded to empty string when using https://github.com/emmetio/expand-abbreviation

For example: The below case

expands to just

<div>
    <dl></dl>
</div>
<footer>
    <p></p>
</footer>

Is this a known issue?

[jens1o]

No, it is not a known issue. The old emmet IS able to resolve it.

Edit: Unfortunately, I can't provide a gif because it would be more than 10MB. :/

[ramya-rao-a]

@jens1o yes, it works in old emmet.

I meant to ask if it is a known issue in the new one or @sergeche would prefer me logging a new issue.

Thanks for looking into it though. Let us know if you find any other feature that previously worked but doesn't now with the new emmet

[jens1o]

I do, don't mention it. 😉

[ramya-rao-a]

Logged emmetio/atom-plugin#23 for upstream issue

[ramya-rao-a]

@sergeche I have created a PR to fix this issue. emmetio/output-renderer#1

Can you please take a look.

Grouping seems to be one of the important cases in emmet abbreviations.

[jens1o]

It has been merged, so this issue can be resolved, can't it?

[ramya-rao-a]

Re-opening as nested groups are still not working as expected

Eg: (div>dl>(dt+dd)*2) eventually gets expanded to

    <div>
       <dl></dl>
   </div>
   <dt></dt>
   <dd></dd>
   <dt></dt>
   <dd></dd>

instead of

    <div>
       <dl>
          <dt></dt>
          <dd></dd>
          <dt></dt>
         <dd></dd>
       </dl>
   </div>

PR to upstream repo has been submitted emmetio/abbreviation#4

[jens1o]

Then you might want to actually open it again? @ramya-rao-a

[ramya-rao-a]

haha! thought I did.

[ramya-rao-a]

Upstream PR emmetio/abbreviation#4 is merged and the changes are pulled into VS Code as well.